[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KPeople part of KDE Frameworks
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2015-02-17 19:54:29
Message-ID: CACcA1Rr22EzP+c+_Of+_+6rOLjmjO=8uTOPsobjdEcu3pyTo9A () mail ! gmail ! com
[Download RAW message or body]

On Tue, Feb 17, 2015 at 7:56 PM, Albert Astals Cid <aacid@kde.org> wrote:
> El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure:
>> Hi,
>> I would like to submit KPeople for review process so it can join the
>> KF5 family in the next 5.8 release.
>>
>> KPeople is a tier 3 framework (because of KService, which will be
>> dropped eventually, without breaking ABI) and it offers cross-source
>> contact aggregation. More information about it can be read on the
>> README [1].
>>
>> Your reviews will be welcome.
>
> Please fix
>
> ./src/widgets/plugins/emaildetailswidget.cpp:50:    return i18n("Email");
> ./src/match.cpp:55:            ret += i18n("E-mail");
>
> Also add context to make it clear if it's an action or a noun.

I think I fixed it now, I also added a couple other i18nc's.

Thanks!
Aleix
[prev in list] [next in list] [prev in thread] [next in thread]