'Re: Review Request 120155: Correctly load non-square icons in KIconLoader'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120155: Correctly load non-square icons in KIconLoader
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-10-30 23:50:40
Message-ID: 20141030235040.23655.2919 () probe ! kde ! org
[Download RAW message or body]

--===============5230050209566338755==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Oct. 1, 2014, 7:45 a.m., David Faure wrote:
> > So, iconthemes aren't made for non-square icons. So why not skip the use of icon \
> > themes for this? Some use of QStandardPaths to locate the icon directly; just \
> > like konqueror finds its indicator_connect.png for instance. Or does this icon \
> > have to be themeable?

Dan, any update or ideas regarding David's and my question (from Sept. 18)?

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120155/#review67754
-----------------------------------------------------------

On Sept. 18, 2014, 8:48 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120155/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 8:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> KIconLoader (and KIconTheme) were always using single int to specify icon size, \
> which implies only square icons. When requesting non-square icons however (such as \
> pixmap sequence animations), the returned QPixmap is deformed. This patch ports all \
> internals of KIconLoader to QSize. 
> 
> Diffs
> -----
> 
> src/kiconengine.cpp 530403e 
> src/kiconloader.h 46d3017 
> src/kiconloader.cpp 2587b46 
> src/kicontheme.h ca04879 
> src/kicontheme.cpp 4f0e522 
> 
> Diff: https://git.reviewboard.kde.org/r/120155/diff/
> 
> 
> Testing
> -------
> 
> QIcon icon = QIcon::fromTheme(QLatin1String("process-working"));
> QPixmap pix = icon.pixmap(22, 8 * 22);
> 
> With this patch, the pix looks as expected.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

--===============5230050209566338755==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120155/">https://git.reviewboard.kde.org/r/120155/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 1st, 2014, 7:45 a.m. UTC, <b>David \
Faure</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So, iconthemes aren't made for non-square icons. So \
why not skip the use of icon themes for this? Some use of QStandardPaths to locate \
the icon directly; just like konqueror finds its indicator_connect.png for instance. \
Or does this icon have to be themeable?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dan, \
any update or ideas regarding David's and my question (from Sept. 18)?</p></pre> <br \
/>

<p>- Christoph</p>

<br />
<p>On September 18th, 2014, 8:48 p.m. UTC, Dan Vrátil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Dan Vrátil.</div>

<p style="color: grey;"><i>Updated Sept. 18, 2014, 8:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KIconLoader (and KIconTheme) were always using single \
int to specify icon size, which implies only square icons. When requesting non-square \
icons however (such as pixmap sequence animations), the returned QPixmap is deformed. \
This patch ports all internals of KIconLoader to QSize.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QIcon icon = \
QIcon::fromTheme(QLatin1String("process-working")); QPixmap pix = icon.pixmap(22, 8 * \
22);</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With this patch, the pix looks as expected.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kiconengine.cpp <span style="color: grey">(530403e)</span></li>

 <li>src/kiconloader.h <span style="color: grey">(46d3017)</span></li>

 <li>src/kiconloader.cpp <span style="color: grey">(2587b46)</span></li>

 <li>src/kicontheme.h <span style="color: grey">(ca04879)</span></li>

 <li>src/kicontheme.cpp <span style="color: grey">(4f0e522)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120155/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5230050209566338755==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 