'Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-10-30 22:46:48
Message-ID: 20141030224648.23656.74375 () probe ! kde ! org
[Download RAW message or body]

--===============5007205427936265746==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120909/#review69560
-----------------------------------------------------------

> Previously (kde4) KFileItem was doing an extra effort into figuring out the \
> miemtype for remotes url but now it is not

Is this the reason I don't get folder icons on FTP anymore either?

- Kai Uwe Broulik

On Okt. 30, 2014, 10:42 nachm., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120909/
> -----------------------------------------------------------
> 
> (Updated Okt. 30, 2014, 10:42 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Set inode/directory mimetype for folders
> 
> 
> Diffs
> -----
> 
> smb/kio_smb_browse.cpp 67e2fa0 
> 
> Diff: https://git.reviewboard.kde.org/r/120909/diff/
> 
> 
> Testing
> -------
> 
> Previously (kde4) KFileItem was doing an extra effort into figuring out the \
> miemtype for remotes url but now it is not (at least not by default). 
> Since we already know that the item is a directory we can set the mimetype already, \
> saving roundtrips and making samba kioslave show folder icons again (and faster \
> since we save a stat). 
> Would be nice if somebody from frameworks (kio) could confirm that the situation \
> regarding mimetypes in frameworks have changed. 
> 
> Thanks,
> 
> Àlex Fiestas
> 
> 

--===============5007205427936265746==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120909/">https://git.reviewboard.kde.org/r/120909/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Previously (kde4) KFileItem was doing an extra effort into figuring out the \
miemtype for remotes url but now it is not</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Is this the reason I don't get folder icons on FTP \
anymore either?</p></pre>  <br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On Oktober 30th, 2014, 10:42 nachm. UTC, Àlex Fiestas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated Okt. 30, 2014, 10:42 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Set inode/directory mimetype for folders</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Previously (kde4) KFileItem was doing an extra effort \
into figuring out the miemtype for remotes url but now it is not (at least not by \
default).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since we already know that the item is a directory we \
can set the mimetype already, saving roundtrips and making samba kioslave show folder \
icons again (and faster since we save a stat).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
be nice if somebody from frameworks (kio) could confirm that the situation regarding \
mimetypes in frameworks have changed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>smb/kio_smb_browse.cpp <span style="color: grey">(67e2fa0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120909/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5007205427936265746==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 