'Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-10-24 22:42:43
Message-ID: 20141024224243.18179.34486 () probe ! kde ! org
[Download RAW message or body]

--===============1623809714346604227==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120641/
-----------------------------------------------------------

(Updated Oct. 24, 2014, 10:42 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: attica

Description
-------

Turn virtuals that are not virtuals into Q_DECL_OVERRIDE

Also rename setNameAccessManager into setNam so that it actually overrides the base. \
I've serached in lxr.kde.org and there's no calls to any of the two so we're fine.

Diffs
-----

  src/deletejob.h 90a4578 
  src/getjob.h 2ec9d76 
  src/itemjob.h 8a373c3 
  src/listjob.h 05f351e 
  src/postjob.h 90bb8f4 
  src/putjob.h 6267a78 
  src/qtplatformdependent.cpp efd49aa 
  src/qtplatformdependent_p.h 4be2f2e 

Diff: https://git.reviewboard.kde.org/r/120641/diff/

Testing
-------

Compiles

Thanks,

Albert Astals Cid

--===============1623809714346604227==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120641/">https://git.reviewboard.kde.org/r/120641/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated Oct. 24, 2014, 10:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
attica
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Turn virtuals that are not virtuals into \
Q_DECL_OVERRIDE</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also rename setNameAccessManager into \
setNam so that it actually overrides the base. I've serached in lxr.kde.org and \
there's no calls to any of the two so we're fine.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/deletejob.h <span style="color: grey">(90a4578)</span></li>

 <li>src/getjob.h <span style="color: grey">(2ec9d76)</span></li>

 <li>src/itemjob.h <span style="color: grey">(8a373c3)</span></li>

 <li>src/listjob.h <span style="color: grey">(05f351e)</span></li>

 <li>src/postjob.h <span style="color: grey">(90bb8f4)</span></li>

 <li>src/putjob.h <span style="color: grey">(6267a78)</span></li>

 <li>src/qtplatformdependent.cpp <span style="color: grey">(efd49aa)</span></li>

 <li>src/qtplatformdependent_p.h <span style="color: grey">(4be2f2e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120641/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1623809714346604227==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 