'Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-10-24 22:40:12
Message-ID: 20141024224012.18178.95899 () probe ! kde ! org
[Download RAW message or body]

--===============5959372524521084553==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120640/
-----------------------------------------------------------

(Updated Oct. 24, 2014, 10:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: karchive

Description
-------

Turn virtuals into Q_DECL_OVERRIDE since it's what they really are.

Also remove putChar that tried to be an override but putChar is not virtual anymore \
in QIODevice and thus we don't need to reimplement it to say it's unsuported

Diffs
-----

  src/kcompressiondevice.h 39a3206 
  src/kgzipfilter.h d74ef8a 
  src/klimitediodevice_p.h dbc1ebf 
  src/knonefilter.h 9314ea2 
  src/kxzfilter.h 59f00f6 
  src/karchivedirectory.h 60225d0 
  src/karchivefile.h c7d2e0e 
  src/kbzip2filter.h 72e9756 

Diff: https://git.reviewboard.kde.org/r/120640/diff/

Testing
-------

Compiles

Thanks,

Albert Astals Cid

--===============5959372524521084553==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120640/">https://git.reviewboard.kde.org/r/120640/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated Oct. 24, 2014, 10:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Turn virtuals into Q_DECL_OVERRIDE since it's what \
they really are.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also remove putChar that tried to be an \
override but putChar is not virtual anymore in QIODevice and thus we don't need to \
reimplement it to say it's unsuported</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcompressiondevice.h <span style="color: grey">(39a3206)</span></li>

 <li>src/kgzipfilter.h <span style="color: grey">(d74ef8a)</span></li>

 <li>src/klimitediodevice_p.h <span style="color: grey">(dbc1ebf)</span></li>

 <li>src/knonefilter.h <span style="color: grey">(9314ea2)</span></li>

 <li>src/kxzfilter.h <span style="color: grey">(59f00f6)</span></li>

 <li>src/karchivedirectory.h <span style="color: grey">(60225d0)</span></li>

 <li>src/karchivefile.h <span style="color: grey">(c7d2e0e)</span></li>

 <li>src/kbzip2filter.h <span style="color: grey">(72e9756)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120640/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5959372524521084553==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 