'Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2014-08-22 8:40:10
Message-ID: 20140822084010.8733.34067 () probe ! kde ! org
[Download RAW message or body]

--===============4264891323843123267==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119895/#review65011
-----------------------------------------------------------

The correct spelling is "migrator". The class should be renamed accordingly.

- David Jarvie

On Aug. 22, 2014, 6:25 a.m., Laurent Montel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119895/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 6:25 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Krammer.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Class helps user to migrate config file and ui file to new location
> 
> 
> Diffs
> -----
> 
> src/lib/CMakeLists.txt 26eb5a1 
> src/lib/util/kdelibs4configmigrater.h PRE-CREATION 
> src/lib/util/kdelibs4configmigrater.cpp PRE-CREATION 
> autotests/CMakeLists.txt 75d1293 
> autotests/data/appui1rc PRE-CREATION 
> autotests/data/appuirc PRE-CREATION 
> autotests/data/foo1rc PRE-CREATION 
> autotests/data/foorc PRE-CREATION 
> autotests/kdelibs4configmigratertest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119895/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laurent Montel
> 
> 

--===============4264891323843123267==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119895/">https://git.reviewboard.kde.org/r/119895/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
correct spelling is "migrator". The class should be renamed accordingly.</p></pre>  \
<br />

<p>- David Jarvie</p>

<br />
<p>On August 22nd, 2014, 6:25 a.m. UTC, Laurent Montel wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Kevin Krammer.</div>
<div>By Laurent Montel.</div>

<p style="color: grey;"><i>Updated Aug. 22, 2014, 6:25 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Class helps user to migrate config file and ui file to \
new location</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/CMakeLists.txt <span style="color: grey">(26eb5a1)</span></li>

 <li>src/lib/util/kdelibs4configmigrater.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/lib/util/kdelibs4configmigrater.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: grey">(75d1293)</span></li>

 <li>autotests/data/appui1rc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/data/appuirc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/data/foo1rc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/data/foorc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/kdelibs4configmigratertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119895/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4264891323843123267==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 