From kde-frameworks-devel Fri Aug 22 08:40:10 2014 From: "David Jarvie" Date: Fri, 22 Aug 2014 08:40:10 +0000 To: kde-frameworks-devel Subject: Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new Message-Id: <20140822084010.8733.34067 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=140869684932249 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4147585616807126924==" --===============4147585616807126924== Content-Type: multipart/alternative; boundary="===============4264891323843123267==" --===============4264891323843123267== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65011 ----------------------------------------------------------- The correct spelling is "migrator". The class should be renamed accordingly. - David Jarvie On Aug. 22, 2014, 6:25 a.m., Laurent Montel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119895/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 6:25 a.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Krammer. > > > Repository: kcoreaddons > > > Description > ------- > > Class helps user to migrate config file and ui file to new location > > > Diffs > ----- > > src/lib/CMakeLists.txt 26eb5a1 > src/lib/util/kdelibs4configmigrater.h PRE-CREATION > src/lib/util/kdelibs4configmigrater.cpp PRE-CREATION > autotests/CMakeLists.txt 75d1293 > autotests/data/appui1rc PRE-CREATION > autotests/data/appuirc PRE-CREATION > autotests/data/foo1rc PRE-CREATION > autotests/data/foorc PRE-CREATION > autotests/kdelibs4configmigratertest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119895/diff/ > > > Testing > ------- > > > Thanks, > > Laurent Montel > > --===============4264891323843123267== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/

The correct spelling is "migrator". The class should be renamed accordingly.

- David Jarvie

On August 22nd, 2014, 6:25 a.m. UTC, Laurent Montel wrote:

Review request for KDE Frameworks, David Faure and Kevin Krammer.

By Laurent Montel.

Updated Aug. 22, 2014, 6:25 a.m.

Repository: kcoreaddons

Description

Class helps user to migrate config file and ui file to new location

Diffs

src/lib/CMakeLists.txt (26eb5a1)
src/lib/util/kdelibs4configmigrater.h (PRE-CREATION)
src/lib/util/kdelibs4configmigrater.cpp (PRE-CREATION)
autotests/CMakeLists.txt (75d1293)
autotests/data/appui1rc (PRE-CREATION)
autotests/data/appuirc (PRE-CREATION)
autotests/data/foo1rc (PRE-CREATION)
autotests/data/foorc (PRE-CREATION)
autotests/kdelibs4configmigratertest.cpp (PRE-CREATION)

View Diff

--===============4264891323843123267==-- --===============4147585616807126924== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============4147585616807126924==--