'Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-08-12 9:33:53
Message-ID: 20140812093353.14668.65349 () probe ! kde ! org
[Download RAW message or body]

--===============2649887158271358772==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review64357
-----------------------------------------------------------

After some discussion with the SDK and Book groups in the sprint, I think we should \
move this into the kde:kwidgetsaddons repository, in an examples subdirectory.

- Aleix Pol Gonzalez

On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 9:33 a.m.)
> 
> 
> Review request for KDE Examples, KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: kdeexamples
> 
> 
> Description
> -------
> 
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
> 
> Comments appreciated,
> 
> 
> Diffs
> -----
> 
> kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac 
> kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 
> kdeui/kmessagewidgetdemo/window.h d3a67c8 
> kdeui/kmessagewidgetdemo/window.cpp 9786da6 
> 
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
> 
> 
> Testing
> -------
> 
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've \
> commented the line. 
> 
> Thanks,
> 
> Laurent Navet
> 
> 

--===============2649887158271358772==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114933/">https://git.reviewboard.kde.org/r/114933/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After \
some discussion with the SDK and Book groups in the sprint, I think we should move \
this into the kde:kwidgetsaddons repository, in an examples subdirectory.</p></pre>  \
<br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On August 12th, 2014, 9:33 a.m. UTC, Laurent Navet wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Examples, KDE Frameworks and Sune Vuorela.</div>
<div>By Laurent Navet.</div>

<p style="color: grey;"><i>Updated Aug. 12, 2014, 9:33 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeexamples
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is part of Google Code-IN Contest.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> As I'm no more student, I've waited for the end of the contest to work on \
it.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Comments appreciated,</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regression on KTextedit::setClickMessage(), as it \
don't exist in QTextEdit I've commented the line.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/kmessagewidgetdemo/CMakeLists.txt <span style="color: \
grey">(12ef4ac)</span></li>

 <li>kdeui/kmessagewidgetdemo/main.cpp <span style="color: \
grey">(d3a5bf0)</span></li>

 <li>kdeui/kmessagewidgetdemo/window.h <span style="color: \
grey">(d3a67c8)</span></li>

 <li>kdeui/kmessagewidgetdemo/window.cpp <span style="color: \
grey">(9786da6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114933/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2649887158271358772==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 