From kde-frameworks-devel Tue Aug 12 09:33:53 2014 From: "Aleix Pol Gonzalez" Date: Tue, 12 Aug 2014 09:33:53 +0000 To: kde-frameworks-devel Subject: Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo Message-Id: <20140812093353.14668.65349 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=140783606707307 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5949790299637875359==" --===============5949790299637875359== Content-Type: multipart/alternative; boundary="===============2649887158271358772==" --===============2649887158271358772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review64357 ----------------------------------------------------------- After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory. - Aleix Pol Gonzalez On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114933/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 9:33 a.m.) > > > Review request for KDE Examples, KDE Frameworks and Sune Vuorela. > > > Repository: kdeexamples > > > Description > ------- > > This is part of Google Code-IN Contest. > As I'm no more student, I've waited for the end of the contest to work on it. > > Comments appreciated, > > > Diffs > ----- > > kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac > kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 > kdeui/kmessagewidgetdemo/window.h d3a67c8 > kdeui/kmessagewidgetdemo/window.cpp 9786da6 > > Diff: https://git.reviewboard.kde.org/r/114933/diff/ > > > Testing > ------- > > Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line. > > > Thanks, > > Laurent Navet > > --===============2649887158271358772== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/

After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory.

- Aleix Pol Gonzalez

On August 12th, 2014, 9:33 a.m. UTC, Laurent Navet wrote:

Review request for KDE Examples, KDE Frameworks and Sune Vuorela.

By Laurent Navet.

Updated Aug. 12, 2014, 9:33 a.m.

Repository: kdeexamples

Description

This is part of Google Code-IN Contest.
As I'm no more student, I've waited for the end of the contest to work on it.

Comments appreciated,

Testing

Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line.

Diffs

kdeui/kmessagewidgetdemo/CMakeLists.txt (12ef4ac)
kdeui/kmessagewidgetdemo/main.cpp (d3a5bf0)
kdeui/kmessagewidgetdemo/window.h (d3a67c8)
kdeui/kmessagewidgetdemo/window.cpp (9786da6)

View Diff

--===============2649887158271358772==-- --===============5949790299637875359== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============5949790299637875359==--