'Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2014-08-05 7:50:59
Message-ID: 20140805075059.20973.91949 () probe ! kde ! org
[Download RAW message or body]

--===============2038837827411869376==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 7:50 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
-------

I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper \
class I created long ago to help maintain uniform widths across layouts. You can \
learn more about it from the blog post I wrote back then: \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the \
API a bit, added some documentation, and here it is.

Diffs
-----

  autotests/CMakeLists.txt 854e916 
  autotests/kcolumnresizertest-forms.ui PRE-CREATION 
  autotests/kcolumnresizertest-grid-and-form.ui PRE-CREATION 
  autotests/kcolumnresizertest-grids.ui PRE-CREATION 
  autotests/kcolumnresizertest.h PRE-CREATION 
  autotests/kcolumnresizertest.cpp PRE-CREATION 
  docs/pics/kcolumnresizer.png PRE-CREATION 
  src/CMakeLists.txt 27b9084 
  src/kcolumnresizer.h PRE-CREATION 
  src/kcolumnresizer.cpp PRE-CREATION 
  tests/CMakeLists.txt eccf887 
  tests/kcolumnresizertest.h PRE-CREATION 
  tests/kcolumnresizertest.cpp PRE-CREATION 
  tests/kcolumnresizertest.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118514/diff/

Testing
-------

Manual test program behaves as expected.

Thanks,

Aurélien Gâteau

--===============2038837827411869376==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118514/">https://git.reviewboard.kde.org/r/118514/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Aug. 5, 2014, 7:50 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer \
is a helper class I created long ago to help maintain uniform widths across layouts. \
You can learn more about it from the blog post I wrote back then: \
http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the \
API a bit, added some documentation, and here it is.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual test program behaves as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(854e916)</span></li>

 <li>autotests/kcolumnresizertest-forms.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/kcolumnresizertest-grid-and-form.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/kcolumnresizertest-grids.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/kcolumnresizertest.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/kcolumnresizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>docs/pics/kcolumnresizer.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(27b9084)</span></li>

 <li>src/kcolumnresizer.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/kcolumnresizer.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(eccf887)</span></li>

 <li>tests/kcolumnresizertest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/kcolumnresizertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>tests/kcolumnresizertest.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118514/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2038837827411869376==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 