[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.
From: "Axel Rasmussen" <axel.rasmussen1 () gmail ! com>
Date: 2014-08-05 7:07:04
Message-ID: 20140805070704.20973.94996 () probe ! kde ! org
[Download RAW message or body]
--===============5967507656062900770==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119564/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 7:07 a.m.)
Status
------
This change has been discarded.
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Bugs: 337472
http://bugs.kde.org/show_bug.cgi?id=337472
Repository: extra-cmake-modules
Description
-------
Upstream Qt commit e112c2e altered the way QExplicitlySharedDataPointer behaves by \
default, such that it no longer uses a `static_cast` to cast compatible pointers. A \
nontrivial amount of KDE code (I encountered the build error in KService, although \
there are other users) depends on this functionality, so this commit adds a define to \
the build system which re-enables the code in Qt.
Diffs
-----
kde-modules/KDECompilerSettings.cmake fdc930e
Diff: https://git.reviewboard.kde.org/r/119564/diff/
Testing
-------
I applied this patch, attempted to build KService, and the build succeeded, rather \
than exhibiting the compile errors found in the log provided on the bug report.
Thanks,
Axel Rasmussen
--===============5967507656062900770==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119564/">https://git.reviewboard.kde.org/r/119564/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Axel Rasmussen.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2014, 7:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337472">337472</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Upstream Qt commit e112c2e altered the way \
QExplicitlySharedDataPointer behaves by default, such that it no longer uses a <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">static_cast</code> to cast compatible pointers. A nontrivial \
amount of KDE code (I encountered the build error in KService, although there are \
other users) depends on this functionality, so this commit adds a define to the build \
system which re-enables the code in Qt.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I applied this patch, attempted to build KService, and \
the build succeeded, rather than exhibiting the compile errors found in the log \
provided on the bug report.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(fdc930e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119564/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5967507656062900770==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic