'Review Request 119198: Don't search default paths when finding lconvert.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 119198: Don't search default paths when finding lconvert.
From:       "Michael Palimaka" <kensington () gentoo ! org>
Date:       2014-07-09 14:12:20
Message-ID: 20140709141220.19519.43139 () probe ! kde ! org
[Download RAW message or body]

--===============7097867339436511982==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119198/
-----------------------------------------------------------

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Repository: extra-cmake-modules

Description
-------

Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one
will be used instead of the one alongside Qt5::lrelease. This could cause Qt4
lconvert to be incorrectly used on some systems.

Diffs
-----

  modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 
  modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af 

Diff: https://git.reviewboard.kde.org/r/119198/diff/

Testing
-------

When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. \
Previously Qt4 version was used as it exists in /usr/bin.

Thanks,

Michael Palimaka

--===============7097867339436511982==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119198/">https://git.reviewboard.kde.org/r/119198/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Michael Palimaka.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Otherwise, if lconvert exists in normal system paths \
(eg. /usr/bin) that one<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> will be used instead of the one \
alongside Qt5::lrelease. This could cause Qt4<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> lconvert to be \
incorrectly used on some systems.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When building solid-5.0.0, Qt5 lconvert from \
lrelease_path is now correctly used. Previously Qt4 version was used as it exists in \
/usr/bin.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMPoQmTools.cmake <span style="color: \
grey">(3ce695817cb3da5ec9eebec86e632438c5941ee6)</span></li>

 <li>modules/ECMCreateQmFromPoFiles.cmake <span style="color: \
grey">(4a31a93e7900780dc5b9424b148f19f5c22061af)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119198/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7097867339436511982==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 