--===============2634055511526086367== Content-Type: multipart/alternative; boundary="===============7097867339436511982==" --===============7097867339436511982== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/ ----------------------------------------------------------- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description ------- Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one will be used instead of the one alongside Qt5::lrelease. This could cause Qt4 lconvert to be incorrectly used on some systems. Diffs ----- modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af Diff: https://git.reviewboard.kde.org/r/119198/diff/ Testing ------- When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. Thanks, Michael Palimaka --===============7097867339436511982== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

By Michael Palimaka.

Repository: extra-cmake-modules

Description

Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one
will be used instead of the one alongside Qt5::lrelease. This could cause Qt4
lconvert to be incorrectly used on some systems.

Testing

When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin.

Diffs

modules/ECMPoQmTools.cmake (3ce695817cb3da5ec9eebec86e632438c5941ee6)
modules/ECMCreateQmFromPoFiles.cmake (4a31a93e7900780dc5b9424b148f19f5c22061af)

View Diff

--===============7097867339436511982==-- --===============2634055511526086367== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============2634055511526086367==--