[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 116014: Add a FindEgl module
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-02-24 15:08:23
Message-ID: 20140224150823.13755.26633 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 24, 2014, 3:51 p.m., Alex Merry wrote:
> > Three things:
> > - what projects are using it? I guess KWin is one; any others?
> > - it needs to set the DESCRIPTION and URL package properties (from \
> > FeatureSummary)
> > - I've been aiming to create imported targets in new find modules, because \
> > they're easier to use (see FindSharedMimeInfo.cmake for an example, or the \
> > modules in kimageformats for better examples).
Currently KWin and KInfoCenter are using egl. But also plasma-framework is soon going \
to need it (that's the reason I opened the review ;-) ).
Other points I will try to address (keep in mind that my cmake knowledge might not be \
sufficient).
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116014/#review50705
-----------------------------------------------------------
On Feb. 24, 2014, 2:08 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116014/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 2:08 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a FindEgl module
>
> This module finds the egl library through pkg-config.
>
>
> Diffs
> -----
>
> find-modules/FindEgl.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/116014/diff/
>
>
> Testing
> -------
>
> Adjusted KWin to find egl through this cmake module. Picks up egl, compiles and \
> links.
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116014/">https://git.reviewboard.kde.org/r/116014/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2014, 3:51 p.m. CET, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Three things:
- what projects are using it? I guess KWin is one; any others?
- it needs to set the DESCRIPTION and URL package properties (from FeatureSummary)
- I've been aiming to create imported targets in new find modules, because \
they're easier to use (see FindSharedMimeInfo.cmake for an example, or the \
modules in kimageformats for better examples).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently KWin and \
KInfoCenter are using egl. But also plasma-framework is soon going to need it \
(that's the reason I opened the review ;-) ).
Other points I will try to address (keep in mind that my cmake knowledge might not be \
sufficient).</pre> <br />
<p>- Martin</p>
<br />
<p>On February 24th, 2014, 2:08 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2014, 2:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a FindEgl module
This module finds the egl library through pkg-config.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adjusted KWin to find egl through this cmake module. Picks up egl, \
compiles and links.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindEgl.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116014/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic