This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ |
On February 24th, 2014, 3:51 p.m. CET, Alex Merry wrote:
Three things: - what projects are using it? I guess KWin is one; any others? - it needs to set the DESCRIPTION and URL package properties (from FeatureSummary) - I've been aiming to create imported targets in new find modules, because they're easier to use (see FindSharedMimeInfo.cmake for an example, or the modules in kimageformats for better examples).
Currently KWin and KInfoCenter are using egl. But also plasma-framework is soon going to need it (that's the reason I opened the review ;-) ). Other points I will try to address (keep in mind that my cmake knowledge might not be sufficient).
- Martin
On February 24th, 2014, 2:08 p.m. CET, Martin Gräßlin wrote:
Review request for KDE Frameworks and Alex Merry.
By Martin Gräßlin.
Updated Feb. 24, 2014, 2:08 p.m.
Repository:
extra-cmake-modules
Description
Testing
Diffs
|