[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115028: Inline deprecated KUser::fullName() method
From: "David Faure" <faure () kde ! org>
Date: 2014-02-22 18:46:52
Message-ID: 20140222184652.7230.85276 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50554
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Feb. 22, 2014, 5:28 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 5:28 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Inline deprecated KUser::fullName() method
>
>
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
>
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
>
>
> Diffs
> -----
>
> src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f
> src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0
> src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d
>
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
>
>
> Testing
> -------
>
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never passed for me).
>
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115028/">https://git.reviewboard.kde.org/r/115028/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On February 22nd, 2014, 5:28 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Inline deprecated \
KUser::fullName() method
Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
KCOREADDONS_NO_DEPRECATED is the macro controlled by
generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">configures, compiles, \
tests pass (well, except KDirWatch-FAM, which has never passed for me).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/util/kuser.h <span style="color: \
grey">(2b6e6ed92bc1465945f36f2fde821f36fa51585f)</span></li>
<li>src/lib/util/kuser_unix.cpp <span style="color: \
grey">(8a3a39d379ca863b4906bb01228c5e01a5b955b0)</span></li>
<li>src/lib/util/kuser_win.cpp <span style="color: \
grey">(6a6cbb1751bd569d8684f8e11add1ef304c0a94d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115028/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic