'Re: Review Request 115897: Remove FindDocBook*.cmake'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115897: Remove FindDocBook*.cmake
From:       "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date:       2014-02-22 18:29:00
Message-ID: 20140222182900.7230.95909 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115897/#review50553
-----------------------------------------------------------

As this was already committed, can this RR be closed?

- Luigi Toscano

On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115897/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 11:45 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, David Faure, Kevin \
> Ottens, and Luigi Toscano. 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Remove FindDocBook*.cmake
> 
> These are only really useful to kdoctools, so they may as well live
> there.
> 
> (NB: after looking at how kdoctools uses the information from these files, I suspect they \
> won't even be needed for the compatibility macros that are intended to end up in \
> kde4support). 
> 
> Diffs
> -----
> 
> find-modules/FindDocBookXML.cmake b6d623e4e5ca40cdda4c895a19a0dc273831703a 
> find-modules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c 
> 
> Diff: https://git.reviewboard.kde.org/r/115897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115897/">https://git.reviewboard.kde.org/r/115897/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">As this was already committed, can this RR be \
closed?</pre>  <br />

<p>- Luigi Toscano</p>

<br />
<p>On February 19th, 2014, 11:45 p.m. UTC, Alex Merry wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, David Faure, Kevin \
Ottens, and Luigi Toscano.</div> <div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated Feb. 19, 2014, 11:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
FindDocBook*.cmake

These are only really useful to kdoctools, so they may as well live
there.

(NB: after looking at how kdoctools uses the information from these files, I suspect they \
won&#39;t even be needed for the compatibility macros that are intended to end up in \
kde4support).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>find-modules/FindDocBookXML.cmake <span style="color: \
grey">(b6d623e4e5ca40cdda4c895a19a0dc273831703a)</span></li>

 <li>find-modules/FindDocBookXSL.cmake <span style="color: \
grey">(a7320aed66b72c92f0286658e38b7fc32266790c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115897/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 