'Re: Review Request 115909: Remove unused dependency from krunner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115909: Remove unused dependency from krunner
From:       "Michael Palimaka" <kensington () gentoo ! org>
Date:       2014-02-22 15:42:42
Message-ID: 20140222154242.7230.70830 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115909/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 3:42 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: krunner

Description
-------

There does not appear to be any actual KCompletion usage, so remove it.

Diffs
-----

  src/runnercontext.cpp 8b7461459ead6ff8c18549531f1b5c9baf1df3fa 
  CMakeLists.txt ebae16d0610c5c53aac34e9134db5d4b0e47903b 
  src/CMakeLists.txt 0f8221fc175f51da32a5abcc96bdeca2c9b0e17b 
  src/abstractrunner.h cee292812075db59c13703de37dc1e983c3d8968 
  src/runnercontext.h c6441b7a1bb92df5549d26f45183c1ff7ce157e6 

Diff: https://git.reviewboard.kde.org/r/115909/diff/

Testing
-------

Builds. Tests pass.

Thanks,

Michael Palimaka

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115909/">https://git.reviewboard.kde.org/r/115909/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated Feb. 22, 2014, 3:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
krunner
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There does not appear \
to be any actual KCompletion usage, so remove it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Tests \
pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/runnercontext.cpp <span style="color: \
grey">(8b7461459ead6ff8c18549531f1b5c9baf1df3fa)</span></li>

 <li>CMakeLists.txt <span style="color: \
grey">(ebae16d0610c5c53aac34e9134db5d4b0e47903b)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(0f8221fc175f51da32a5abcc96bdeca2c9b0e17b)</span></li>

 <li>src/abstractrunner.h <span style="color: \
grey">(cee292812075db59c13703de37dc1e983c3d8968)</span></li>

 <li>src/runnercontext.h <span style="color: \
grey">(c6441b7a1bb92df5549d26f45183c1ff7ce157e6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115909/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 