[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113910: Add basic KArchive examples
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-11-24 21:32:00
Message-ID: 20131124213200.17136.55030 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/#review44355
-----------------------------------------------------------
> Looking for feedback on:
> License? Currently BSD.
BSD is one of the acceptable licenses:
http://techbase.kde.org/Policies/Licensing_Policy
That page doesn't specify anything in particular about license for example code. \
Perhaps it should, but that doesn't affect this patch of course :).
> Code comments. More, less?
> Readability?
Looks good to me.
> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example
Thanks for working on this! It's a great initiative.
tier1/karchive/examples/helloworld/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113910/#comment31720>
It might make sense to add the REQUIRED keyword here, and possibly even a \
version, to show good practice.
- Stephen Kelly
On Nov. 20, 2013, 6:50 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113910/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 6:50 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This adds 2 examples to KArchive.
> - helloworld: Very basic. Shows how to use with CMake and create archives.
> - tarlocalfiles: Shows how to add local files to an archive.
>
> Looking for feedback on:
> License? Currently BSD.
> Code comments. More, less?
> Readability?
>
> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example
>
>
> Diffs
> -----
>
> tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION
> tier1/karchive/examples/helloworld/main.cpp PRE-CREATION
> tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION
> tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113910/diff/
>
>
> Testing
> -------
>
> Builds and runs without errors.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113910/">http://git.reviewboard.kde.org/r/113910/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Looking for \
feedback on: > License? Currently BSD.
BSD is one of the acceptable licenses:
http://techbase.kde.org/Policies/Licensing_Policy
That page doesn't specify anything in particular about license for example code. \
Perhaps it should, but that doesn't affect this patch of course :).
> Code comments. More, less?
> Readability?
Looks good to me.
> Other examples I'm working on:
> helloworld with qmake
> something with KCompressionDevice
> perhaps a minimal ark like example
Thanks for working on this! It's a great initiative.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113910/diff/1/?file=215058#file215058line7" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/karchive/examples/helloworld/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">7</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">find_package</span><span class="p">(</span><span \
class="s">KArchive</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It might \
make sense to add the REQUIRED keyword here, and possibly even a version, to show \
good practice.</pre> </div>
<br />
<p>- Stephen Kelly</p>
<br />
<p>On November 20th, 2013, 6:50 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 6:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds 2 examples to KArchive.
- helloworld: Very basic. Shows how to use with CMake and create archives.
- tarlocalfiles: Shows how to add local files to an archive.
Looking for feedback on:
License? Currently BSD.
Code comments. More, less?
Readability?
Other examples I'm working on:
helloworld with qmake
something with KCompressionDevice
perhaps a minimal ark like example</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds and runs without errors.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/karchive/examples/helloworld/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/helloworld/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/tarlocalfiles/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/karchive/examples/tarlocalfiles/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113910/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic