[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 114076: Set KDE4_INCLUDES in KDE4SupportConfig
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-11-24 21:21:40
Message-ID: 20131124212140.14706.26038 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 24, 2013, 9:20 p.m., Stephen Kelly wrote:
> >
Nothing should need find_package(KDELibs4) at all anymore. Uses of it should be \
removed (or replaced with kde4support, if that's not already there), and then \
KDELibs4Config.cmake should be removed from kdelibs.git/frameworks.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114076/#review44353
-----------------------------------------------------------
On Nov. 24, 2013, 2:07 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114076/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2013, 2:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Set KDE4_INCLUDES in KDE4SupportConfig.
>
> This allows to compile kde-runtime without find_package(KDELibs4),
> which seems otherwise redundant with find_package(KDE4Support).
>
>
> Diffs
> -----
>
> tier4/kde4support/KDE4SupportConfig.cmake.in 1a8c9c4
>
> Diff: http://git.reviewboard.kde.org/r/114076/diff/
>
>
> Testing
> -------
>
> kde-runtime compiles without find_package(KDELibs4)
>
>
> Thanks,
>
> David Faure
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114076/">http://git.reviewboard.kde.org/r/114076/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing should need \
find_package(KDELibs4) at all anymore. Uses of it should be removed (or replaced with \
kde4support, if that's not already there), and then KDELibs4Config.cmake should \
be removed from kdelibs.git/frameworks.</pre> <br />
<p>- Stephen</p>
<br />
<p>On November 24th, 2013, 2:07 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2013, 2:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set KDE4_INCLUDES in KDE4SupportConfig.
This allows to compile kde-runtime without find_package(KDELibs4),
which seems otherwise redundant with find_package(KDE4Support).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde-runtime compiles without find_package(KDELibs4)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/kde4support/KDE4SupportConfig.cmake.in <span style="color: \
grey">(1a8c9c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114076/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic