[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113503: make dbus dependency optional in JobWidgets
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-10-31 14:21:54
Message-ID: 20131031142154.3565.92796 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113503/#review42744
-----------------------------------------------------------
tier2/kjobwidgets/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113503/#comment30900>
You don't need COMPONENTS here. I'm not sure about whether it's needed in the \
next line.
tier2/kjobwidgets/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113503/#comment30901>
You probably want if (Qt5DBus_FOUND) ? I think that the target is only created if \
it is found, but I can't be sure. A Config file can set its _FOUND variable to false \
if a necessary condition is not met (eg a file missing which should be packaged like \
a macros file - See the Qt config files for more.)
tier2/kjobwidgets/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113503/#comment30902>
Ditto.
Indentation.
tier2/kjobwidgets/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113503/#comment30903>
Use PRIVATE, not LINK_PRIVATE (new in 2.8.12).
Indentation and extra newline.
tier2/kjobwidgets/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113503/#comment30904>
Indent.
- Stephen Kelly
On Oct. 30, 2013, 10:08 a.m., Sune Vuorela wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113503/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 10:08 a.m.)
>
>
> Review request for KDE Frameworks, kdelibs and Stephen Kelly.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Make dbus dependency optional in JobWidgets
>
> Many don't have dbus available on all platforms, especially windows, but JobWidgets \
> is very much useful without it.
>
> Diffs
> -----
>
> tier2/kjobwidgets/CMakeLists.txt ca53024
> tier2/kjobwidgets/src/CMakeLists.txt 0a575a6
> tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2
> tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407
>
> Diff: http://git.reviewboard.kde.org/r/113503/diff/
>
>
> Testing
> -------
>
> build tested on windows without dbus. not yet tested on other platforms
>
>
> Thanks,
>
> Sune Vuorela
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113503/">http://git.reviewboard.kde.org/r/113503/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113503/diff/2/?file=206492#file206492line12" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kjobwidgets/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">12</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">find_package</span><span class="p">(</span><span class="s">Qt5</span> \
<span class="o">${</span><span class="nv">QT_REQUIRED_VERSION</span><span \
class="o">}</span> <span class="s">REQUIRED</span> <span class="s">NO_MODULE</span> \
<span class="s">COMPONENTS</span> <span class="s">Widgets</span><span class="hl"> \
</span><span class="s"><span class="hl">DBus</span></span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">12</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span \
class="p">(</span><span class="s">Qt5</span> <span class="o">${</span><span \
class="nv">QT_REQUIRED_VERSION</span><span class="o">}</span> <span \
class="s">REQUIRED</span> <span class="s">NO_MODULE</span> <span \
class="s">COMPONENTS</span> <span class="s">Widgets</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
don't need COMPONENTS here. I'm not sure about whether it's needed in the \
next line.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113503/diff/2/?file=206492#file206492line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kjobwidgets/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">TARGET</span> <span \
class="s">Qt5::DBus</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
probably want if (Qt5DBus_FOUND) ? I think that the target is only created if it is \
found, but I can't be sure. A Config file can set its _FOUND variable to false if \
a necessary condition is not met (eg a file missing which should be packaged like a \
macros file - See the Qt config files for more.)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113503/diff/2/?file=206493#file206493line13" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kjobwidgets/src/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">12</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="s">TARGET</span> <span \
class="s">Qt5::DBus</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ditto.
Indentation.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113503/diff/2/?file=206493#file206493line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kjobwidgets/src/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">target_link_libraries</span><span class="p">(</span><span \
class="s">KJobWidgets</span> <span class="s">LINK_PRIVATE</span> <span \
class="s">Qt5::DBus</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use \
PRIVATE, not LINK_PRIVATE (new in 2.8.12).
Indentation and extra newline.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113503/diff/2/?file=206493#file206493line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier2/kjobwidgets/src/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">list</span><span class="p">(</span><span class="s">APPEND</span> <span \
class="s">KJOBWIDGETS_PUBLIC_HEADERS</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Indent.</pre> </div>
<br />
<p>- Stephen Kelly</p>
<br />
<p>On October 30th, 2013, 10:08 a.m. UTC, Sune Vuorela wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs and Stephen Kelly.</div>
<div>By Sune Vuorela.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2013, 10:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make dbus dependency optional in JobWidgets
Many don't have dbus available on all platforms, especially windows, but \
JobWidgets is very much useful without it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build tested on windows without dbus. not yet tested on other \
platforms</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/kjobwidgets/CMakeLists.txt <span style="color: grey">(ca53024)</span></li>
<li>tier2/kjobwidgets/src/CMakeLists.txt <span style="color: \
grey">(0a575a6)</span></li>
<li>tier2/kjobwidgets/src/config-kjobwidgets.h.cmake <span style="color: \
grey">(35b64a2)</span></li>
<li>tier2/kjobwidgets/tests/kjobtrackerstest.cpp <span style="color: \
grey">(7a61407)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113503/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic