[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113503: make dbus dependency optional in JobWidgets
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2013-11-15 18:20:15
Message-ID: 20131115182015.4127.74929 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113503/#review43742
-----------------------------------------------------------
Any chance to see Stephen's comments addressed or this patch is abandoned?
- Kevin Ottens
On Oct. 30, 2013, 10:08 a.m., Sune Vuorela wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113503/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 10:08 a.m.)
>
>
> Review request for KDE Frameworks, kdelibs and Stephen Kelly.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Make dbus dependency optional in JobWidgets
>
> Many don't have dbus available on all platforms, especially windows, but JobWidgets \
> is very much useful without it.
>
> Diffs
> -----
>
> tier2/kjobwidgets/CMakeLists.txt ca53024
> tier2/kjobwidgets/src/CMakeLists.txt 0a575a6
> tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2
> tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407
>
> Diff: http://git.reviewboard.kde.org/r/113503/diff/
>
>
> Testing
> -------
>
> build tested on windows without dbus. not yet tested on other platforms
>
>
> Thanks,
>
> Sune Vuorela
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113503/">http://git.reviewboard.kde.org/r/113503/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any chance to see \
Stephen's comments addressed or this patch is abandoned?</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On October 30th, 2013, 10:08 a.m. UTC, Sune Vuorela wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs and Stephen Kelly.</div>
<div>By Sune Vuorela.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2013, 10:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make dbus dependency optional in JobWidgets
Many don't have dbus available on all platforms, especially windows, but \
JobWidgets is very much useful without it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build tested on windows without dbus. not yet tested on other \
platforms</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier2/kjobwidgets/CMakeLists.txt <span style="color: grey">(ca53024)</span></li>
<li>tier2/kjobwidgets/src/CMakeLists.txt <span style="color: \
grey">(0a575a6)</span></li>
<li>tier2/kjobwidgets/src/config-kjobwidgets.h.cmake <span style="color: \
grey">(35b64a2)</span></li>
<li>tier2/kjobwidgets/tests/kjobtrackerstest.cpp <span style="color: \
grey">(7a61407)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113503/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic