'Review Request 113302: Static KEncodingFileDialog in staging/kio'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 113302: Static KEncodingFileDialog in staging/kio
From:       "Teo Mrnjavac" <teo () kde ! org>
Date:       2013-10-17 14:04:43
Message-ID: 20131017140443.6468.59709 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113302/
-----------------------------------------------------------

Review request for KDE Frameworks, David Faure and Kevin Ottens.

Repository: kdelibs

Description
-------

This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff \
from KFileDialog to KFileWidget to reduce duplication.

Diffs
-----

  kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 
  kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd 
  kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 
  kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e 
  staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a \
  staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION 
  staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad 
  staging/kio/src/filewidgets/kfilewidget.cpp \
824ac563f3f8c463426f0a45e792f107ac402a40 

Diff: http://git.reviewboard.kde.org/r/113302/diff/

Testing
-------

Seems to work fine in a test app.

Thanks,

Teo Mrnjavac

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113302/">http://git.reviewboard.kde.org/r/113302/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Teo Mrnjavac.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes KEncodingFileDialog static, moves it to staging/kio and moves \
some stuff from KFileDialog to KFileWidget to reduce duplication.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems to work fine in a test app.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/CMakeLists.txt <span style="color: \
grey">(ac80e393c877280dd8033ec13e8e772afea6d2f9)</span></li>

 <li>kio/kfile/kencodingfiledialog.h <span style="color: \
grey">(abb939abeb000126005f1a1a9c6fd50b8bd322bd)</span></li>

 <li>kio/kfile/kencodingfiledialog.cpp <span style="color: \
grey">(d55d908473aae2859838d88fd776cc65cecf3317)</span></li>

 <li>kio/kfile/kfiledialog.cpp <span style="color: \
grey">(32eb98a4490a31c5ed51150ca3cb7af5375dc67e)</span></li>

 <li>staging/kio/src/filewidgets/CMakeLists.txt <span style="color: \
grey">(e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a)</span></li>

 <li>staging/kio/src/filewidgets/kencodingfiledialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>staging/kio/src/filewidgets/kfilewidget.h <span style="color: \
grey">(f7b162ab39b997274b21f9eff0c6374545e0a9ad)</span></li>

 <li>staging/kio/src/filewidgets/kfilewidget.cpp <span style="color: \
grey">(824ac563f3f8c463426f0a45e792f107ac402a40)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113302/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 