[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2013-08-09 11:59:40
Message-ID: 20130809115940.17061.85582 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37410
-----------------------------------------------------------
tier1/kconfig/src/gui/kconfigloader.h
<http://git.reviewboard.kde.org/r/111908/#comment27683>
Didn't spot it the first time, sorry...
We generally use KConfigGroup by value if I'm not mistaken. So should be a const \
ref instead of a pointer.
- Kevin Ottens
On Aug. 9, 2013, 5:20 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:20 a.m.)
>
>
> Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Add KConfigLoader from Plasma Framework to KConfigGui
>
> The ConfigLoader is way to awesome to not be directly in KConfig.
>
>
> Diffs
> -----
>
> tier1/kconfig/autotests/CMakeLists.txt c913da3
> tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION
> tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION
> tier1/kconfig/src/gui/CMakeLists.txt 0913349
> tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION
> tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION
> tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111908/">http://git.reviewboard.kde.org/r/111908/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111908/diff/3/?file=177534#file177534line130" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tier1/kconfig/src/gui/kconfigloader.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">130</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KConfigLoader</span><span class="p">(</span><span class="k">const</span> \
<span class="n">KConfigGroup</span> <span class="o">*</span><span \
class="n">config</span><span class="p">,</span> <span class="n">QIODevice</span> \
<span class="o">*</span><span class="n">xml</span><span class="p">,</span> <span \
class="n">QObject</span> <span class="o">*</span><span class="n">parent</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Didn't \
spot it the first time, sorry...
We generally use KConfigGroup by value if I'm not mistaken. So should be a const \
ref instead of a pointer.</pre> </div>
<br />
<p>- Kevin</p>
<br />
<p>On August 9th, 2013, 5:20 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Aaron J. Seigo.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 5:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add KConfigLoader from Plasma Framework to KConfigGui
The ConfigLoader is way to awesome to not be directly in KConfig.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kconfig/autotests/CMakeLists.txt <span style="color: \
grey">(c913da3)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/CMakeLists.txt <span style="color: \
grey">(0913349)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloaderhandler_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111908/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic