[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-08-09 5:20:52
Message-ID: 20130809052052.7356.99488 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 7:20 a.m.)
Review request for KDE Frameworks, Plasma and Aaron J. Seigo.
Changes
-------
fixed the issues outlined by David E. and Kevin
Description
-------
Add KConfigLoader from Plasma Framework to KConfigGui
The ConfigLoader is way to awesome to not be directly in KConfig.
Diffs (updated)
-----
tier1/kconfig/autotests/CMakeLists.txt c913da3
tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION
tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION
tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION
tier1/kconfig/src/gui/CMakeLists.txt 0913349
tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION
tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION
tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION
tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111908/diff/
Testing
-------
Thanks,
Martin Gräßlin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111908/">http://git.reviewboard.kde.org/r/111908/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Aaron J. Seigo.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 7:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixed the issues outlined by David E. and Kevin</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add KConfigLoader from Plasma Framework to KConfigGui
The ConfigLoader is way to awesome to not be directly in KConfig.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kconfig/autotests/CMakeLists.txt <span style="color: \
grey">(c913da3)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/autotests/kconfigloadertest.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/CMakeLists.txt <span style="color: \
grey">(0913349)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloader_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tier1/kconfig/src/gui/kconfigloaderhandler_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111908/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic