[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D29840: enumeration memory games multiple_dataset
From:       emmanuel charruau <noreply () phabricator ! kde ! org>
Date:       2020-06-10 8:17:51
Message-ID: 379505820c7fd95e4e33159de394adce () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

echarruau added a comment.


  Hi,
  Maybe because you use a diff that you commit? No idea on my side but
  could you ask Timothée or Johnny to kbao why? What is sure is that I
  don't see it.
  
  Le mar. 9 juin 2020 Ã  11:45, Deepak Kumar
  <noreply@phabricator.kde.org> a écrit :
  
  > dekumar added a comment. View Revision
  > 
  > In D29840#674920 <https://phabricator.kde.org/D29840#674920>, @echarruau wrote:
  > 
  > Changes are ok.
  >  I would still need to see the process test table where you will document how you \
do the tests to be sure that you are not breaking any of the other memory activity.  \
>   > I have fixed that in this commit \
> > https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5
  >  Not getting why it's not updated over here.
  > 
  > REPOSITORY
  >  R2 <https://phabricator.kde.org/source/gcompris/> GCompris
  > 
  > REVISION DETAIL
  >  https://phabricator.kde.org/D29840
  > 
  > To: dekumar, GCompris: Improvements, jjazeix, timotheegiet, AkshayCHD, \
amankumargupta, echarruau  >  Cc: kde-edu, narvaez, apol

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D29840

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, AkshayCHD, \
                amankumargupta, echarruau
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">echarruau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D29840">View Revision</a></tr></table><br \
/><div><div><p>Hi,<br /> Maybe because you use a diff that you commit? No idea on my \
side but<br /> could you ask Timothée or Johnny to kbao why? What is sure is that \
I<br /> don&#039;t see it.</p>

<p>Le mar. 9 juin 2020 Ã  11:45, Deepak Kumar<br />
&lt;noreply@phabricator.kde.org&gt; a écrit :</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>dekumar added a comment. View Revision</p>

<p>In <a href="https://phabricator.kde.org/D29840#674920" style="background-color: \
#e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D29840#674920</a>, <a \
href="https://phabricator.kde.org/p/echarruau/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@echarruau</a> wrote:</p>

<p>Changes are ok.<br />
 I would still need to see the process test table where you will document how you do \
the tests to be sure that you are not breaking any of the other memory activity.</p>

<p>I have fixed that in this commit <a \
href="https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5</a><br \
/>  Not getting why it&#039;s not updated over here.</p>

<p>REPOSITORY<br />
 <a href="https://phabricator.kde.org/source/gcompris/" style="background-color: \
#e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">R2</a> GCompris</p>

<p>REVISION DETAIL<br />
 <a href="https://phabricator.kde.org/D29840" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D29840</a></p>

<p>To: dekumar, GCompris: Improvements, jjazeix, timotheegiet, AkshayCHD, \
amankumargupta, echarruau<br />  Cc: kde-edu, narvaez, \
apol</p></blockquote></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 \
GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29840">https://phabricator.kde.org/D29840</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix, timotheegiet, \
AkshayCHD, amankumargupta, echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]