[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D29482: Add support for openbabel 3
From:       Antonio Rojas <noreply () phabricator ! kde ! org>
Date:       2020-06-09 14:26:41
Message-ID: 1a1480beb577b2a215255a2179747580 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

arojas added a comment.


  In D29482#674938 <https://phabricator.kde.org/D29482#674938>, @joscott wrote:
  
  > > What's the full path of OpenBabel3Config.cmake and its second line \
("get_filename_component") on Debian?  >
  > I was so focused on the linker errors I overlooked that. It's installed at \
/usr/lib/x86_64-linux-gnu/cmake/openbabel3/OpenBabel3Config.cmake.  Here is its full \
content (on the second/third lines that's actually a hard line break, not a wrap).  
  
  The linker errors are caused by this (the pthread::pthread target is added in \
OpenBabel3_EXPORTS.cmake, which is failing to get imported for you.  
  This comes from the hardcoded REL_REF defined in \
https://github.com/openbabel/openbabel/blob/openbabel-3-1-1/CMakeLists.txt#L761 which \
is wrong for Debian (doesn't account for the extra /x86_64-linux-gnu/ subdir). \
Hardconding this doesn't look right to me, you should ask them to fix this

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D29482

To: arojas, #kalzium, yurchor
Cc: joscott, yurchor, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">arojas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D29482">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D29482#674938" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D29482#674938</a>, <a \
href="https://phabricator.kde.org/p/joscott/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@joscott</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>What&#039;s the full path of OpenBabel3Config.cmake \
and its second line (&quot;get_filename_component&quot;) on Debian?</p></blockquote>

<p>I was so focused on the linker errors I overlooked that. It&#039;s installed at \
/usr/lib/x86_64-linux-gnu/cmake/openbabel3/OpenBabel3Config.cmake.  Here is its full \
content (on the second/third lines that&#039;s actually a hard line break, not a \
wrap).</p></div> </blockquote>

<p>The linker errors are caused by this (the pthread::pthread target is added in \
OpenBabel3_EXPORTS.cmake, which is failing to get imported for you.</p>

<p>This comes from the hardcoded REL_REF defined in <a \
href="https://github.com/openbabel/openbabel/blob/openbabel-3-1-1/CMakeLists.txt#L761" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/openbabel/openbabel/blob/openbabel-3-1-1/CMakeLists.txt#L761</a> \
which is wrong for Debian (doesn&#039;t account for the extra /x86_64-linux-gnu/ \
subdir). Hardconding this doesn&#039;t look right to me, you should ask them to fix \
this</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 \
Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D29482">https://phabricator.kde.org/D29482</a></div></div><br \
/><div><strong>To: </strong>arojas, Kalzium, yurchor<br /><strong>Cc: \
</strong>joscott, yurchor, kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]