[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D15937: Do not alter the state of the Scheduler while evaluating
From:       Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date:       2018-10-12 20:19:45
Message-ID: cee0e69562b430cff9b95a2ef284ca6d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

TallFurryMan added inline comments.

INLINE COMMENTS

> scheduler.cpp:692
>      evaluateOnlyB->setEnabled(true);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:838
>  {
> -    setJobManipulation(index.isValid());
> +    setJobManipulation(!Options::sortSchedulerJobs() && index.isValid());
>  }

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:895
>      queueTable->selectRow(destinationRow);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

> scheduler.cpp:928
>      queueTable->selectRow(destinationRow);
> -    setJobManipulation(true);
> +    setJobManipulation(!Options::sortSchedulerJobs());
>  

Regression: this creates a link between job sorting and delete button being disabled.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D15937

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol

[Attachment #3 (text/html)]

<table><tr><td style="">TallFurryMan added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15937">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15937#inline-87829">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">scheduler.cpp:692</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">evaluateOnlyB</span><span \
style="color: #aa2211">-&gt;</span><span class="n">setEnabled</span><span \
class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">    <span class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#304a96"><span class="bright">true</span></span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span class="bright"></span><span \
class="n"><span class="bright">Options</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sortSchedulerJobs</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Regression: this creates a link between job sorting and delete button being \
disabled.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15937#inline-87830">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">scheduler.cpp:838</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">    <span class="n">setJobManipulation</span><span \
class="p">(</span><span class="n">index</span><span class="p">.</span><span \
class="n">isValid</span><span class="p">());</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span class="bright"></span><span \
class="n"><span class="bright">Options</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sortSchedulerJobs</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">&amp;&amp;</span></span><span \
class="bright"> </span><span class="n">index</span><span class="p">.</span><span \
class="n">isValid</span><span class="p">());</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "><span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Regression: this creates a link between job sorting and delete button being \
disabled.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15937#inline-87831">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">scheduler.cpp:895</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    \
<span class="n">queueTable</span><span style="color: #aa2211">-&gt;</span><span \
class="n">selectRow</span><span class="p">(</span><span \
class="n">destinationRow</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#304a96"><span class="bright">true</span></span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span class="bright"></span><span \
class="n"><span class="bright">Options</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sortSchedulerJobs</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Regression: this creates a link between job sorting and delete button being \
disabled.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D15937#inline-87832">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">scheduler.cpp:928</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    \
<span class="n">queueTable</span><span style="color: #aa2211">-&gt;</span><span \
class="n">selectRow</span><span class="p">(</span><span \
class="n">destinationRow</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#304a96"><span class="bright">true</span></span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">setJobManipulation</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span class="bright"></span><span \
class="n"><span class="bright">Options</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">sortSchedulerJobs</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span>);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Regression: this creates a link between job sorting and delete button being \
disabled.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15937">https://phabricator.kde.org/D15937</a></div></div><br \
/><div><strong>To: </strong>TallFurryMan, mutlaqja, wreissenberger<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]