[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D14665: Edit scheduler jobs with double-click and update icon to match Capture module.
From:       Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date:       2018-10-12 20:16:12
Message-ID: 75bcb3e3caa26a69c25fe875ffe21507 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

TallFurryMan added inline comments.

INLINE COMMENTS

> scheduler.cpp:854
> +        queueDownB->setEnabled(false);
> +        removeFromQueueB->setEnabled(false);
> +    }

Side-effect: this prevents jobs from being deleted.
If the feature "job manipulation" is made related to sorting jobs only, preventing \
that manipulation also prevent deletion.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14665

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">TallFurryMan added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14665">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14665#inline-87827">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">scheduler.cpp:854</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">queueDownB</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setEnabled</span><span class="p">(</span><span style="color: \
#304a96">false</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">removeFromQueueB</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setEnabled</span><span class="p">(</span><span style="color: \
#304a96">false</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Side-effect: this prevents jobs from being deleted.<br /> If the \
feature &quot;job manipulation&quot; is made related to sorting jobs only, preventing \
that manipulation also prevent deletion.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14665">https://phabricator.kde.org/D14665</a></div></div><br \
/><div><strong>To: </strong>TallFurryMan, mutlaqja, wreissenberger<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]