[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 129646: Fix the soname of kalzium internal libraries
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-12-13 0:45:35
Message-ID: 20161213004535.16852.32036 () mimi ! kde ! org
[Download RAW message or body]
--===============6125157435671062189==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129646/#review101403
-----------------------------------------------------------
Ship it!
After discussing in IRC, let's do this. We can review the versioning depending on how \
development goes over time.
- Aleix Pol Gonzalez
On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129646/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 1:06 a.m.)
>
>
> Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas \
> Cord-Landwehr.
>
> Bugs: 373565
> http://bugs.kde.org/show_bug.cgi?id=373565
>
>
> Repository: kalzium
>
>
> Description
> -------
>
> GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4.
> Define local variables for the version of the libraries.
>
>
> Diffs
> -----
>
> CMakeLists.txt 9844a34
> compoundviewer/CMakeLists.txt 2109d84
> libscience/CMakeLists.txt d7c23a4
>
> Diff: https://git.reviewboard.kde.org/r/129646/diff/
>
>
> Testing
> -------
>
> Compiles, and now:
>
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
> -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to \
> "/opt/kf5/lib/x86_64-linux-gnu"
> I could not test the other library (I should compile avogadro) but I suspect that \
> it should be the same.
>
> Thanks,
>
> Luigi Toscano
>
>
--===============6125157435671062189==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129646/">https://git.reviewboard.kde.org/r/129646/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After \
discussing in IRC, let's do this. We can review the versioning depending on how \
development goes over time.</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 13th, 2016, 1:06 a.m. CET, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas \
Cord-Landwehr.</div> <div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2016, 1:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=373565">373565</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by \
kdelibs4. Define local variables for the version of the libraries.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, and now:
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
-- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" \
to "/opt/kf5/lib/x86_64-linux-gnu"
I could not test the other library (I should compile avogadro) but I suspect that it \
should be the same.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9844a34)</span></li>
<li>compoundviewer/CMakeLists.txt <span style="color: grey">(2109d84)</span></li>
<li>libscience/CMakeLists.txt <span style="color: grey">(d7c23a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129646/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6125157435671062189==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic