[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 129646: Fix the soname of kalzium internal libraries
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-12-13 0:38:14
Message-ID: 20161213003814.16852.19971 () mimi ! kde ! org
[Download RAW message or body]
--===============3606243568341574290==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 13, 2016, 1:19 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 66
> > <https://git.reviewboard.kde.org/r/129646/diff/1/?file=487340#file487340line66>
> >
> > This will need updating.
> >
> > How about using:
> > ```
> > # KDE Application Version, managed by release script
> > set (KDE_APPLICATIONS_VERSION_MAJOR "16")
> > set (KDE_APPLICATIONS_VERSION_MINOR "12")
> > set (KDE_APPLICATIONS_VERSION_MICRO "0")
> > ```
> >
> > Then have
> > `set(LIBSOVERSION \
> > "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")`
>
> Luigi Toscano wrote:
> I did the exactly opposite change on few kdemultimedia modules. It is true that \
> it's more likely for those libraries to became part of Frameworks than those \
> internal ones, and that starting with 16 (soon 17) means complications to go back \
> to 5. But... not sure.
If it becomes an actual framework the library will adopt the KF5 prefix (e.g. \
libKF5CoreAddons.so.5.28.0).
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129646/#review101400
-----------------------------------------------------------
On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129646/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 1:06 a.m.)
>
>
> Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas \
> Cord-Landwehr.
>
> Bugs: 373565
> http://bugs.kde.org/show_bug.cgi?id=373565
>
>
> Repository: kalzium
>
>
> Description
> -------
>
> GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4.
> Define local variables for the version of the libraries.
>
>
> Diffs
> -----
>
> CMakeLists.txt 9844a34
> compoundviewer/CMakeLists.txt 2109d84
> libscience/CMakeLists.txt d7c23a4
>
> Diff: https://git.reviewboard.kde.org/r/129646/diff/
>
>
> Testing
> -------
>
> Compiles, and now:
>
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
> -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to \
> "/opt/kf5/lib/x86_64-linux-gnu"
> I could not test the other library (I should compile avogadro) but I suspect that \
> it should be the same.
>
> Thanks,
>
> Luigi Toscano
>
>
--===============3606243568341574290==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129646/">https://git.reviewboard.kde.org/r/129646/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 13th, 2016, 1:19 a.m. CET, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129646/diff/1/?file=487340#file487340line66" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ecm_setup_version("5.0.0"</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
will need updating.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">How about using:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%"><span></span># KDE Application Version, managed by release script set \
(KDE_APPLICATIONS_VERSION_MAJOR "16") set (KDE_APPLICATIONS_VERSION_MINOR \
"12") set (KDE_APPLICATIONS_VERSION_MICRO "0")
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Then have <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">set(LIBSOVERSION \
"${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")</code></p></pre>
</blockquote>
<p>On December 13th, 2016, 1:24 a.m. CET, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
the exactly opposite change on few kdemultimedia modules. It is true that it's more \
likely for those libraries to became part of Frameworks than those internal ones, \
and that starting with 16 (soon 17) means complications to go back to 5. But... not \
sure.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If it becomes an actual framework the library will adopt the KF5 prefix \
(e.g. libKF5CoreAddons.so.5.28.0).</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On December 13th, 2016, 1:06 a.m. CET, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas \
Cord-Landwehr.</div> <div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2016, 1:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=373565">373565</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by \
kdelibs4. Define local variables for the version of the libraries.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, and now:
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
-- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" \
to "/opt/kf5/lib/x86_64-linux-gnu"
I could not test the other library (I should compile avogadro) but I suspect that it \
should be the same.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9844a34)</span></li>
<li>compoundviewer/CMakeLists.txt <span style="color: grey">(2109d84)</span></li>
<li>libscience/CMakeLists.txt <span style="color: grey">(d7c23a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129646/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3606243568341574290==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic