'Re: Review Request 123984: Port Away from KLocale in coordinate_system.cpp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123984: Port Away from KLocale in coordinate_system.cpp
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-06-03 6:35:06
Message-ID: 20150603063506.8350.84908 () mimi ! kde ! org
[Download RAW message or body]

--===============0584225031484053279==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123984/
-----------------------------------------------------------

(Updated June 3, 2015, 6:35 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Changes
-------

Submitted with commit 52f6dceabeefffaa2ded391f9dc22e740624c6db by David E. Narvaez to \
branch master.

Repository: kig

Description
-------

This particular class made heavy use of KLocale so I want to make sure I
got this one right.

Diffs
-----

  misc/coordinate_system.cpp 3095ea692e5ae91f4793b95d3408170a872a0986 

Diff: https://git.reviewboard.kde.org/r/123984/diff/

Testing
-------

1. Create a point, then right click and set the coordinates
2. Change the zoom area with View->Select Zoom Area

In all of these cases the coordinates you see should be properly formatted according \
to your locale (e.g., decimal points, signs) and all your inputs should be validated \
properly.

Thanks,

David Narváez

--===============0584225031484053279==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123984/">https://git.reviewboard.kde.org/r/123984/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated June 3, 2015, 6:35 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 52f6dceabeefffaa2ded391f9dc22e740624c6db by David \
E. Narvaez to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This particular class made heavy use of KLocale so I want to make sure I \
got this one right.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Create a point, then \
right click and set the coordinates</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Change the zoom area \
with View-&gt;Select Zoom Area</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In all of these cases the coordinates you see should \
be properly formatted according to your locale (e.g., decimal points, signs) and all \
your inputs should be validated properly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>misc/coordinate_system.cpp <span style="color: \
grey">(3095ea692e5ae91f4793b95d3408170a872a0986)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123984/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0584225031484053279==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 