'Re: Review Request 122081: Generate activities qrc files in the build directory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 122081: Generate activities qrc files in the build directory
From:       "Johnny Jazeix" <jazeix () gmail ! com>
Date:       2015-06-02 20:06:39
Message-ID: 20150602200639.8350.75662 () mimi ! kde ! org
[Download RAW message or body]

--===============8980385489987185279==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122081/#review81095
-----------------------------------------------------------

Works fine using Qt5.5.0 beta.
As we can't set the minimum Qt version to 5.4.2, we need to guard the changes between \
if(${Qt5_VERSION} STRGREATER "5.4.1") endif(). So maybe letting the *.qrc in the \
.gitignore for now. Also, it does not work on Windows (console stays locked at [  1%] \
Generating ../../share/gcompris-qt/rcc/activities.rcc and rcc is running at 15-30% of \
cpu). Maybe the redirection? I don't know much but I can take a look if necessary.

- Johnny Jazeix

On Jan. 20, 2015, 3:54 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122081/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 3:54 a.m.)
> 
> 
> Review request for KDE Edu and Bruno Coudoin.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> Just had to compile from a user to another and saw this issue. It's quite \
> straightforward, I don't think it will be a problem. 
> 
> Diffs
> -----
> 
> .gitignore be9278f 
> cmake/rcc.cmake 15c5cee 
> 
> Diff: https://git.reviewboard.kde.org/r/122081/diff/
> 
> 
> Testing
> -------
> 
> It works as it used to.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============8980385489987185279==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122081/">https://git.reviewboard.kde.org/r/122081/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works \
fine using Qt5.5.0 beta. As we can't set the minimum Qt version to 5.4.2, we need to \
guard the changes between if(${Qt5_VERSION} STRGREATER "5.4.1") endif(). So maybe \
letting the *.qrc in the .gitignore for now. Also, it does not work on Windows \
(console stays locked at [  1%] Generating ../../share/gcompris-qt/rcc/activities.rcc \
and rcc is running at 15-30% of cpu). Maybe the redirection? I don't know much but I \
can take a look if necessary.</p></pre>  <br />

<p>- Johnny Jazeix</p>

<br />
<p>On January 20th, 2015, 3:54 a.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Bruno Coudoin.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2015, 3:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gcompris
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Just had to compile from a user to another and saw \
this issue. It's quite straightforward, I don't think it will be a problem.</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It works as it used to.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>.gitignore <span style="color: grey">(be9278f)</span></li>

 <li>cmake/rcc.cmake <span style="color: grey">(15c5cee)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122081/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8980385489987185279==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 