'Re: Review Request 123822: [Cantor] KListWidget ported to QListWidget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123822: [Cantor] KListWidget ported to QListWidget
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2015-05-18 0:32:58
Message-ID: 20150518003258.16315.24589 () mimi ! kde ! org
[Download RAW message or body]

--===============7422978517882326650==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123822/
-----------------------------------------------------------

(Updated May 18, 2015, 12:32 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.

Changes
-------

Submitted with commit d9fdc1dd13c8ca4e6f28a1a5e9ac02ae59f9da50 by Filipe Saraiva to \
branch master.

Repository: cantor

Description
-------

KListWidget is deprecated for KF5. The library was ported to QListWidget

Diffs
-----

  src/backendchoosedialog.cpp c2d1e65 
  src/backendchooser.ui 3552d10 

Diff: https://git.reviewboard.kde.org/r/123822/diff/

Testing
-------

Build is ok. The list is utilized just for backend selection. This selection was \
tested and it is ok.

Thanks,

Filipe Saraiva

--===============7422978517882326650==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123822/">https://git.reviewboard.kde.org/r/123822/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.</div> <div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated May 18, 2015, 12:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit d9fdc1dd13c8ca4e6f28a1a5e9ac02ae59f9da50 by Filipe \
Saraiva to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KListWidget is deprecated for KF5. The library was \
ported to QListWidget</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build is ok. The list is utilized just for backend \
selection. This selection was tested and it is ok.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backendchoosedialog.cpp <span style="color: grey">(c2d1e65)</span></li>

 <li>src/backendchooser.ui <span style="color: grey">(3552d10)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123822/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7422978517882326650==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 