[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 123825: [Cantor] KStandardDirs ported to QSrandardPaths
From: "Filipe Saraiva" <filipe () kde ! org>
Date: 2015-05-18 0:32:58
Message-ID: 20150518003258.16315.1810 () mimi ! kde ! org
[Download RAW message or body]
--===============7623282804435570351==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123825/
-----------------------------------------------------------
(Updated May 18, 2015, 12:32 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
Changes
-------
Submitted with commit 2af4705c3391345444c95a6e63a84355fa6d66ac by Filipe Saraiva to \
branch master.
Repository: cantor
Description
-------
KStandardDirs is deprecated for KF5. The library was ported to QStandardPaths. I used \
[porting notes page](https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs) \
about KStandardDirs to do it.
Diffs
-----
src/backends/R/rbackend.cpp e128520
src/backends/R/rsession.cpp 1d1aeac
src/backends/maxima/maximakeywords.cpp 1ea1a5c
src/backends/maxima/maximasession.cpp a150194
src/backends/maxima/testmaxima.cpp 65111aa
src/backends/python/pythonextensions.cpp 665a628
src/backends/python/pythonkeywords.cpp e3e425c
src/backends/python3/python3session.cpp 5846ba1
src/backends/sage/sagekeywords.cpp 2b6f763
src/backends/scilab/scilabkeywords.cpp 0ac8003
src/cantor.cpp 25d15b6
src/latexentry.cpp 0b8321d
src/lib/expression.cpp 2fb9286
src/lib/latexrenderer.cpp 75f7cda
src/loadedexpression.cpp 02c8790
src/worksheet.cpp 9ff8cf1
Diff: https://git.reviewboard.kde.org/r/123825/diff/
Testing
-------
Tests performed:
* Maxima keywords loaded;
* Can find Python 3 executable and can run it;
* Sage keywords loaded;
* Open examples;
* Process latex entries correctly;
* Export to latex format working correctly.
Missing tests:
* Run and find R executable (I do not have R in my machine).
Thanks,
Filipe Saraiva
--===============7623282804435570351==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123825/">https://git.reviewboard.kde.org/r/123825/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated May 18, 2015, 12:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2af4705c3391345444c95a6e63a84355fa6d66ac by Filipe \
Saraiva to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KStandardDirs is deprecated for KF5. The library was \
ported to QStandardPaths. I used <a \
href="https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">porting notes page</a> about KStandardDirs to do it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests performed: <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> Maxima keywords loaded; \
</em> Can find Python 3 executable and can run it; <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Sage \
keywords loaded; </em> Open examples;
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> Process latex entries correctly; </em> Export to latex \
format working correctly.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Missing tests:
* Run and find R executable (I do not have R in my machine).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/R/rbackend.cpp <span style="color: grey">(e128520)</span></li>
<li>src/backends/R/rsession.cpp <span style="color: grey">(1d1aeac)</span></li>
<li>src/backends/maxima/maximakeywords.cpp <span style="color: \
grey">(1ea1a5c)</span></li>
<li>src/backends/maxima/maximasession.cpp <span style="color: \
grey">(a150194)</span></li>
<li>src/backends/maxima/testmaxima.cpp <span style="color: \
grey">(65111aa)</span></li>
<li>src/backends/python/pythonextensions.cpp <span style="color: \
grey">(665a628)</span></li>
<li>src/backends/python/pythonkeywords.cpp <span style="color: \
grey">(e3e425c)</span></li>
<li>src/backends/python3/python3session.cpp <span style="color: \
grey">(5846ba1)</span></li>
<li>src/backends/sage/sagekeywords.cpp <span style="color: \
grey">(2b6f763)</span></li>
<li>src/backends/scilab/scilabkeywords.cpp <span style="color: \
grey">(0ac8003)</span></li>
<li>src/cantor.cpp <span style="color: grey">(25d15b6)</span></li>
<li>src/latexentry.cpp <span style="color: grey">(0b8321d)</span></li>
<li>src/lib/expression.cpp <span style="color: grey">(2fb9286)</span></li>
<li>src/lib/latexrenderer.cpp <span style="color: grey">(75f7cda)</span></li>
<li>src/loadedexpression.cpp <span style="color: grey">(02c8790)</span></li>
<li>src/worksheet.cpp <span style="color: grey">(9ff8cf1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123825/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7623282804435570351==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic