[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122406: Initial port of KUrl to QUrl
From: "Lucas Hermann Negri" <lucashnegri () gmail ! com>
Date: 2015-03-17 16:48:35
Message-ID: 20150317164835.15053.70110 () mimi ! kde ! org
[Download RAW message or body]
--===============4142144368318521373==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122406/
-----------------------------------------------------------
(Updated March 17, 2015, 4:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh Ngo.
Repository: cantor
Description
-------
Initial port of **KUrl** to **QUrl**. Touched many files as it is like a *domino \
effect*. It is not just a search/replace, as the semantics and API have changed.
In the process also re-enabled the latex rendering in latex/text entries.
Diffs
-----
src/backends/R/rbackend.h 5eae64f
src/backends/R/rbackend.cpp 3d95c79
src/backends/R/rexpression.cpp f0f9abd
src/backends/lua/luabackend.h a590840
src/backends/lua/luabackend.cpp 3e25c77
src/backends/lua/luaexpression.cpp 7e16454
src/backends/maxima/maximabackend.h 3139c0e
src/backends/maxima/maximabackend.cpp 4cb4acb
src/backends/maxima/maximaexpression.cpp 14a5b59
src/backends/null/nullexpression.cpp 2f2994d
src/backends/octave/octavebackend.h da98bbb
src/backends/octave/octavebackend.cpp 7c40d88
src/backends/octave/octaveexpression.cpp 44426ce
src/backends/python/pythonexpression.cpp 83a502a
src/backends/python2/python2backend.h 4dcad25
src/backends/python2/python2backend.cpp 1f16665
src/backends/python3/python3backend.h 3930d88
src/backends/python3/python3backend.cpp bfd00ba
src/backends/qalculate/qalculatebackend.h 72a948e
src/backends/qalculate/qalculatebackend.cpp 272fe3a
src/backends/qalculate/qalculateexpression.cpp 1891baa
src/backends/sage/sagebackend.h 74d0ff9
src/backends/sage/sagebackend.cpp 57c7265
src/backends/sage/sageexpression.cpp 5aaeaa4
src/backends/scilab/scilabbackend.h 12f621a
src/backends/scilab/scilabbackend.cpp d28e42f
src/backends/scilab/scilabexpression.cpp c91ccf9
src/cantor.h c703f5d
src/cantor.cpp 5194fc7
src/cantor_part.cpp 88ca911
src/epsrenderer.h 6184cc5
src/epsrenderer.cpp fd05f53
src/imageentry.cpp 7ae264d
src/imageresultitem.cpp 77bc20e
src/latexentry.cpp 0671243
src/lib/animationresult.h ddf42c8
src/lib/animationresult.cpp 2572ef7
src/lib/backend.h ca884ae
src/lib/backend.cpp 101ff74
src/lib/epsresult.h cd636e7
src/lib/epsresult.cpp 97e29c0
src/lib/expression.cpp 345198a
src/lib/imageresult.h 8b9dde1
src/lib/imageresult.cpp dbb5542
src/lib/latexresult.h 8970668
src/lib/latexresult.cpp 2b830de
src/lib/result.h 5aec2e5
src/lib/result.cpp e0f8d20
src/loadedexpression.cpp 702b937
src/panelplugins/variablemgr/variablemanagerwidget.cpp fc8551b
src/textentry.cpp 1d1484a
src/textresultitem.cpp 6ffeab0
src/worksheetimageitem.h dc76d90
src/worksheetimageitem.cpp a024be7
src/animationresultitem.cpp 11d227a
src/assistants/runscript/runscriptassistant.cpp c749e2a
Diff: https://git.reviewboard.kde.org/r/122406/diff/
Testing
-------
Tested the functionality that used urls, like the help button, latex rendering, \
plotting, save/load worksheet and variables, export.
Seems to be working, but apart from the latex rendering (epsrendering actually), this \
is not an urgent patch and can wait more testing for a future release, I think.
Thanks,
Lucas Hermann Negri
--===============4142144368318521373==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122406/">https://git.reviewboard.kde.org/r/122406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh \
Ngo.</div> <div>By Lucas Hermann Negri.</div>
<p style="color: grey;"><i>Updated March 17, 2015, 4:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Initial port of <strong style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">KUrl</strong> to <strong style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">QUrl</strong>. Touched many files as it \
is like a <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">domino effect</em>. It is not just a search/replace, as \
the semantics and API have changed.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In the process also \
re-enabled the latex rendering in latex/text entries.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested the functionality that used urls, like the help \
button, latex rendering, plotting, save/load worksheet and variables, export.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Seems to be working, but apart from the latex rendering (epsrendering \
actually), this is not an urgent patch and can wait more testing for a future \
release, I think.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/R/rbackend.h <span style="color: grey">(5eae64f)</span></li>
<li>src/backends/R/rbackend.cpp <span style="color: grey">(3d95c79)</span></li>
<li>src/backends/R/rexpression.cpp <span style="color: grey">(f0f9abd)</span></li>
<li>src/backends/lua/luabackend.h <span style="color: grey">(a590840)</span></li>
<li>src/backends/lua/luabackend.cpp <span style="color: grey">(3e25c77)</span></li>
<li>src/backends/lua/luaexpression.cpp <span style="color: \
grey">(7e16454)</span></li>
<li>src/backends/maxima/maximabackend.h <span style="color: \
grey">(3139c0e)</span></li>
<li>src/backends/maxima/maximabackend.cpp <span style="color: \
grey">(4cb4acb)</span></li>
<li>src/backends/maxima/maximaexpression.cpp <span style="color: \
grey">(14a5b59)</span></li>
<li>src/backends/null/nullexpression.cpp <span style="color: \
grey">(2f2994d)</span></li>
<li>src/backends/octave/octavebackend.h <span style="color: \
grey">(da98bbb)</span></li>
<li>src/backends/octave/octavebackend.cpp <span style="color: \
grey">(7c40d88)</span></li>
<li>src/backends/octave/octaveexpression.cpp <span style="color: \
grey">(44426ce)</span></li>
<li>src/backends/python/pythonexpression.cpp <span style="color: \
grey">(83a502a)</span></li>
<li>src/backends/python2/python2backend.h <span style="color: \
grey">(4dcad25)</span></li>
<li>src/backends/python2/python2backend.cpp <span style="color: \
grey">(1f16665)</span></li>
<li>src/backends/python3/python3backend.h <span style="color: \
grey">(3930d88)</span></li>
<li>src/backends/python3/python3backend.cpp <span style="color: \
grey">(bfd00ba)</span></li>
<li>src/backends/qalculate/qalculatebackend.h <span style="color: \
grey">(72a948e)</span></li>
<li>src/backends/qalculate/qalculatebackend.cpp <span style="color: \
grey">(272fe3a)</span></li>
<li>src/backends/qalculate/qalculateexpression.cpp <span style="color: \
grey">(1891baa)</span></li>
<li>src/backends/sage/sagebackend.h <span style="color: grey">(74d0ff9)</span></li>
<li>src/backends/sage/sagebackend.cpp <span style="color: \
grey">(57c7265)</span></li>
<li>src/backends/sage/sageexpression.cpp <span style="color: \
grey">(5aaeaa4)</span></li>
<li>src/backends/scilab/scilabbackend.h <span style="color: \
grey">(12f621a)</span></li>
<li>src/backends/scilab/scilabbackend.cpp <span style="color: \
grey">(d28e42f)</span></li>
<li>src/backends/scilab/scilabexpression.cpp <span style="color: \
grey">(c91ccf9)</span></li>
<li>src/cantor.h <span style="color: grey">(c703f5d)</span></li>
<li>src/cantor.cpp <span style="color: grey">(5194fc7)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(88ca911)</span></li>
<li>src/epsrenderer.h <span style="color: grey">(6184cc5)</span></li>
<li>src/epsrenderer.cpp <span style="color: grey">(fd05f53)</span></li>
<li>src/imageentry.cpp <span style="color: grey">(7ae264d)</span></li>
<li>src/imageresultitem.cpp <span style="color: grey">(77bc20e)</span></li>
<li>src/latexentry.cpp <span style="color: grey">(0671243)</span></li>
<li>src/lib/animationresult.h <span style="color: grey">(ddf42c8)</span></li>
<li>src/lib/animationresult.cpp <span style="color: grey">(2572ef7)</span></li>
<li>src/lib/backend.h <span style="color: grey">(ca884ae)</span></li>
<li>src/lib/backend.cpp <span style="color: grey">(101ff74)</span></li>
<li>src/lib/epsresult.h <span style="color: grey">(cd636e7)</span></li>
<li>src/lib/epsresult.cpp <span style="color: grey">(97e29c0)</span></li>
<li>src/lib/expression.cpp <span style="color: grey">(345198a)</span></li>
<li>src/lib/imageresult.h <span style="color: grey">(8b9dde1)</span></li>
<li>src/lib/imageresult.cpp <span style="color: grey">(dbb5542)</span></li>
<li>src/lib/latexresult.h <span style="color: grey">(8970668)</span></li>
<li>src/lib/latexresult.cpp <span style="color: grey">(2b830de)</span></li>
<li>src/lib/result.h <span style="color: grey">(5aec2e5)</span></li>
<li>src/lib/result.cpp <span style="color: grey">(e0f8d20)</span></li>
<li>src/loadedexpression.cpp <span style="color: grey">(702b937)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerwidget.cpp <span style="color: \
grey">(fc8551b)</span></li>
<li>src/textentry.cpp <span style="color: grey">(1d1484a)</span></li>
<li>src/textresultitem.cpp <span style="color: grey">(6ffeab0)</span></li>
<li>src/worksheetimageitem.h <span style="color: grey">(dc76d90)</span></li>
<li>src/worksheetimageitem.cpp <span style="color: grey">(a024be7)</span></li>
<li>src/animationresultitem.cpp <span style="color: grey">(11d227a)</span></li>
<li>src/assistants/runscript/runscriptassistant.cpp <span style="color: \
grey">(c749e2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4142144368318521373==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic