[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122410: Fix actual warnings
From: "Lucas Hermann Negri" <lucashnegri () gmail ! com>
Date: 2015-03-17 15:06:31
Message-ID: 20150317150631.15053.40629 () mimi ! kde ! org
[Download RAW message or body]
--===============2635725753053557891==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122410/
-----------------------------------------------------------
(Updated March 17, 2015, 3:06 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh Ngo.
Repository: cantor
Description
-------
Fix actual warnings in the code base (not related to deprecations).
Diffs
-----
src/backends/maxima/maximaexpression.cpp 14a5b59
src/backends/qalculate/qalculateexpression.cpp 1891baa
src/backends/qalculate/qalculateextensions.cpp e2f61e2
src/backends/sage/sagehighlighter.cpp 642a3d9
src/cantor_part.h 24bbfb0
src/cantor_part.cpp 88ca911
Diff: https://git.reviewboard.kde.org/r/122410/diff/
Testing
-------
Warnings disapeared and the application is working as expected, as only one important \
change was performed (a reference to a local object was being returned. I've marked \
it as static to fix it).
Thanks,
Lucas Hermann Negri
--===============2635725753053557891==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122410/">https://git.reviewboard.kde.org/r/122410/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh \
Ngo.</div> <div>By Lucas Hermann Negri.</div>
<p style="color: grey;"><i>Updated March 17, 2015, 3:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix actual warnings in the code base (not related to \
deprecations).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Warnings disapeared and the application is working as \
expected, as only one important change was performed (a reference to a local object \
was being returned. I've marked it as static to fix it).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/maxima/maximaexpression.cpp <span style="color: \
grey">(14a5b59)</span></li>
<li>src/backends/qalculate/qalculateexpression.cpp <span style="color: \
grey">(1891baa)</span></li>
<li>src/backends/qalculate/qalculateextensions.cpp <span style="color: \
grey">(e2f61e2)</span></li>
<li>src/backends/sage/sagehighlighter.cpp <span style="color: \
grey">(642a3d9)</span></li>
<li>src/cantor_part.h <span style="color: grey">(24bbfb0)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(88ca911)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122410/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2635725753053557891==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic