'Re: Review Request 118349: Initial port for step to Qt5/KF5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 118349: Initial port for step to Qt5/KF5
From:       "Pepe Osca" <pposca () gmail ! com>
Date:       2014-05-29 21:07:38
Message-ID: 20140529210738.14701.70948 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118349/
-----------------------------------------------------------

(Updated May 29, 2014, 11:07 p.m.)

Review request for KDE Edu and Aleix Pol Gonzalez.

Changes
-------

Patch issues fixed

Repository: step

Description
-------

Everything builds and runs after porting to KF5

Diffs (updated)
-----

  stepcore/types.h b1259a6 
  stepcore/object.cc fbbb9b3 
  step/worldscene.cc 5f25a6a 
  stepcore/CMakeLists.txt bb6e584 
  step/worldmodel.cc 7051905 
  step/toolgraphics.cc 8367eab 
  step/propertiesbrowser.cc 9064cba 
  step/mainwindow.cc cb3d575 
  step/mainwindow.h 5e46245 
  step/main.cc 1e02dd4 
  step/infobrowser.cc f5e0004 
  step/icons/CMakeLists.txt fc5acc6 
  step/icons/actions/CMakeLists.txt a755344 
  step/gaskdialog.cc PRE-CREATION 
  step/gasgraphics.cc 5005592 
  step/gaskdialog.h PRE-CREATION 
  step/gasgraphics.h d4e241c 
  step/clipboard.cc 19aa48c 
  step/choicesmodel.h PRE-CREATION 
  step/choicesmodel.cc PRE-CREATION 
  step/CMakeLists.txt 03d9f75 
  doc/CMakeLists.txt ee4796c 
  CMakeLists.txt bf53def 

Diff: https://git.reviewboard.kde.org/r/118349/diff/

Testing
-------

Thanks,

Pepe Osca

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118349/">https://git.reviewboard.kde.org/r/118349/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Pepe Osca.</div>

<p style="color: grey;"><i>Updated May 29, 2014, 11:07 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch issues fixed</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
step
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything builds and runs after porting to KF5</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>stepcore/types.h <span style="color: grey">(b1259a6)</span></li>

 <li>stepcore/object.cc <span style="color: grey">(fbbb9b3)</span></li>

 <li>step/worldscene.cc <span style="color: grey">(5f25a6a)</span></li>

 <li>stepcore/CMakeLists.txt <span style="color: grey">(bb6e584)</span></li>

 <li>step/worldmodel.cc <span style="color: grey">(7051905)</span></li>

 <li>step/toolgraphics.cc <span style="color: grey">(8367eab)</span></li>

 <li>step/propertiesbrowser.cc <span style="color: grey">(9064cba)</span></li>

 <li>step/mainwindow.cc <span style="color: grey">(cb3d575)</span></li>

 <li>step/mainwindow.h <span style="color: grey">(5e46245)</span></li>

 <li>step/main.cc <span style="color: grey">(1e02dd4)</span></li>

 <li>step/infobrowser.cc <span style="color: grey">(f5e0004)</span></li>

 <li>step/icons/CMakeLists.txt <span style="color: grey">(fc5acc6)</span></li>

 <li>step/icons/actions/CMakeLists.txt <span style="color: \
grey">(a755344)</span></li>

 <li>step/gaskdialog.cc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>step/gasgraphics.cc <span style="color: grey">(5005592)</span></li>

 <li>step/gaskdialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>step/gasgraphics.h <span style="color: grey">(d4e241c)</span></li>

 <li>step/clipboard.cc <span style="color: grey">(19aa48c)</span></li>

 <li>step/choicesmodel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>step/choicesmodel.cc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>step/CMakeLists.txt <span style="color: grey">(03d9f75)</span></li>

 <li>doc/CMakeLists.txt <span style="color: grey">(ee4796c)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(bf53def)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118349/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 