[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118307: support for Geogebra's Angle objects in KIG ( GSoC 14 )
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-05-27 19:24:59
Message-ID: 20140527192459.19374.46936 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118307/#review58602
-----------------------------------------------------------
This one is pretty straightforward, but I messed the diff by commiting my formatting \
changes (I'm very annoying, I know). Could you refresh the diff please (taking care \
of formatting, of course)?
Also, in the "Testing done" field, that is not a boolean question, you have to write \
what you did to test it in a way that people reviewing the diff can reproduce your \
test results.
- David Narváez
On May 25, 2014, 5:59 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118307/
> -----------------------------------------------------------
>
> (Updated May 25, 2014, 5:59 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch enables KIG to read Angle objects from Geogebra worksheets.
>
>
> Diffs
> -----
>
> filters/geogebra-filter.cpp a0fc6b4
> filters/geogebra.xsl e52fc1d
>
> Diff: https://git.reviewboard.kde.org/r/118307/diff/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Aniket Anvit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118307/">https://git.reviewboard.kde.org/r/118307/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one is pretty \
straightforward, but I messed the diff by commiting my formatting changes (I'm \
very annoying, I know). Could you refresh the diff please (taking care of formatting, \
of course)?
Also, in the "Testing done" field, that is not a boolean question, you have \
to write what you did to test it in a way that people reviewing the diff can \
reproduce your test results.</pre> <br />
<p>- David Narváez</p>
<br />
<p>On May 25th, 2014, 5:59 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated May 25, 2014, 5:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch enables KIG to read Angle objects from Geogebra \
worksheets.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/geogebra-filter.cpp <span style="color: grey">(a0fc6b4)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(e52fc1d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118307/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic