'Re: Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-edu-devel
Subject: Re: Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX
From: "Lucas Hermann Negri" <lucashnegri () gmail ! com>
Date: 2014-05-18 17:44:06
Message-ID: 20140518174406.16614.91155 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On May 11, 2014, 2:01 p.m., Alexander Rieder wrote:
> > the code looks good, and it doesn't crash anymore, so thats definitely a big improvement! \
> > I'm still somewhat surprised that this feature could get so broken somehow.. Are you still \
> > working on bringing back the missing functionality?
> 
> Lucas Hermann Negri wrote:
> I'm not working on it right now.
> 
> I think that the latex export feature can be improved, and this requires some decisions to be \
> made. For example, it currently bundles all the images on the worksheet to an archive file, \
> but there is no distinction between plots / included figures and rendered latex expressions \
> (from math mode); should it omit the rendered latex expressions? 
> Alexander Rieder wrote:
> Hi,
> yes i think that the rendered expressions should be omitted. The way I think this feature \
> should work is that it generates all the files you need to actually run latex on it and \
> render the document. Thus the already rendered formulas do not add any benefit.  Given the \
> target of "give me something i can run latex on", I'm  also not 100% sure if the images \
> should be left in an archive, be put alongside the .tex file or if everything should be put \
> in a new folder. What do you think? 
> Lucas Hermann Negri wrote:
> Hi. I agree, it should omit math rendering. Also, putting files in an archive is not \
> practical for the user. Maybe it could create an 'img' dir and put all the files there. This \
> way is more simple to use IMHO, as the export will not scatter the files around and it will \
> be more easy to avoid overwriting existing files. And it would be nice, as you've said, to \
> make the latex 'ready to run', so automatically adding the corresponding \includegraphics \
> would be nice too. 
> Alexander Rieder wrote:
> yes, this would probably be the best approach. Do you have any interest in working on this, \
> or should I have a look at fixing this myself (might take me a little while to get to it)?

I have interest in working on this issue, but I it may take some time due to other pending \
tasks. Feel free to work on this issue if you want / can!

- Lucas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/#review57716
-----------------------------------------------------------

On April 30, 2014, 11:48 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117917/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 11:48 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latex export procedure always tried to access a null pointer, so it always resulted in a \
> crash. Also, the user was asked about exporting the images too, but the read value was never \
> used. 
> I've fixed the crash, but there is still missing functionality. I've added basic support for \
> exporting the images, since it was ignoring the user option to export images, but it is far \
> from complete since the images are not referenced inside the latex file. 
> 
> Diffs
> -----
> 
> src/latexentry.cpp b3ce962 
> src/worksheet.cpp 082e116 
> 
> Diff: https://git.reviewboard.kde.org/r/117917/diff/
> 
> 
> Testing
> -------
> 
> Latex export seems to be working with or without exporting images too.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117917/">https://git.reviewboard.kde.org/r/117917/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 On May 11th, 2014, 2:01 p.m. UTC, Alexander Rieder wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">the code looks good, and it doesn&#39;t crash \
anymore, so thats definitely a big improvement! I&#39;m still somewhat surprised that this \
feature could get so broken somehow.. Are you still working on bringing back the missing \
functionality?</pre> </blockquote>

On May 11th, 2014, 5:08 p.m. UTC, Lucas Hermann Negri wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not working on it right now.

I think that the latex export feature can be improved, and this requires some decisions to be \
made. For example, it currently bundles all the images on the worksheet to an archive file, but \
there is no distinction between plots / included figures and rendered latex expressions (from \
math mode); should it omit the rendered latex expressions?</pre> </blockquote>

On May 13th, 2014, 3:51 p.m. UTC, Alexander Rieder wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Hi, yes i think that the rendered expressions \
should be omitted. The way I think this feature should work is that it generates all the files \
you need to actually run latex on it and render the document. Thus the already rendered \
formulas do not add any benefit. Given the target of &quot;give me something i can run latex \
on&quot;, I&#39;m also not 100% sure if the images should be left in an archive, be put \
alongside the .tex file or if everything should be put in a new folder. What do you \
think?</pre> </blockquote>

On May 13th, 2014, 4:11 p.m. UTC, Lucas Hermann Negri wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Hi. I agree, it should omit math rendering. \
Also, putting files in an archive is not practical for the user. Maybe it could create an \
&#39;img&#39; dir and put all the files there. This way is more simple to use IMHO, as the \
export will not scatter the files around and it will be more easy to avoid overwriting existing \
files. And it would be nice, as you&#39;ve said, to make the latex &#39;ready to run&#39;, so \
automatically adding the corresponding \includegraphics would be nice too.</pre> </blockquote>

On May 14th, 2014, 9:20 a.m. UTC, Alexander Rieder wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">yes, this would probably be the best \
approach. Do you have any interest in working on this, or should I have a look at fixing this \
myself (might take me a little while to get to it)?</pre> </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I have interest in working on this issue, but \
I it may take some time due to other pending tasks. Feel free to work on this issue if you want \
/ can!</pre>

<p>- Lucas</p>

<br />
<p>On April 30th, 2014, 11:48 p.m. UTC, Lucas Hermann Negri wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 11:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
 <td>
 <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The latex export \
procedure always tried to access a null pointer, so it always resulted in a crash. Also, the \
user was asked about exporting the images too, but the read value was never used.

I&#39;ve fixed the crash, but there is still missing functionality. I&#39;ve added basic \
support for exporting the images, since it was ignoring the user option to export images, but \
it is far from complete since the images are not referenced inside the latex file.</pre> </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Latex export seems to \
be working with or without exporting images too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/latexentry.cpp <span style="color: grey">(b3ce962)</span></li>

 <li>src/worksheet.cpp <span style="color: grey">(082e116)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117917/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 