[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Review Request 117917: Fixes crashes when exporting the worksheet as LaTeX
From: "Lucas Hermann Negri" <lucashnegri () gmail ! com>
Date: 2014-04-30 23:48:09
Message-ID: 20140430234809.13676.86057 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117917/
-----------------------------------------------------------
Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
Repository: cantor
Description
-------
The latex export procedure always tried to access a null pointer, so it always \
resulted in a crash. Also, the user was asked about exporting the images too, but the \
read value was never used.
I've fixed the crash, but there is still missing functionality. I've added basic \
support for exporting the images, since it was ignoring the user option to export \
images, but it is far from complete since the images are not referenced inside the \
latex file.
Diffs
-----
src/latexentry.cpp b3ce962
src/worksheet.cpp 082e116
Diff: https://git.reviewboard.kde.org/r/117917/diff/
Testing
-------
Latex export seems to be working with or without exporting images too.
Thanks,
Lucas Hermann Negri
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117917/">https://git.reviewboard.kde.org/r/117917/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The latex export procedure always tried to access a null pointer, so it \
always resulted in a crash. Also, the user was asked about exporting the images too, \
but the read value was never used.
I've fixed the crash, but there is still missing functionality. I've added \
basic support for exporting the images, since it was ignoring the user option to \
export images, but it is far from complete since the images are not referenced inside \
the latex file.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Latex export seems to be working with or without exporting images \
too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/latexentry.cpp <span style="color: grey">(b3ce962)</span></li>
<li>src/worksheet.cpp <span style="color: grey">(082e116)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic