'Re: Review Request 117636: Add importPackage menu to Sage backend in Cantor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 117636: Add importPackage menu to Sage backend in Cantor
From:       "Alexander Rieder" <alexanderrieder () gmail ! com>
Date:       2014-04-30 21:40:14
Message-ID: 20140430214014.1393.28168 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117636/#review57032
-----------------------------------------------------------

Ship it!

Looks good and works. Sorry for my late review. Please go ahead and commit!

- Alexander Rieder

On April 18, 2014, 8:55 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117636/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 8:55 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Rieder.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> This diff add SagePackagingExtension::importPackage to Sage backend, like in Python \
> 2 backend. It enable a menu item in menu bar to import packages in Sage \
> environment. 
> 
> Diffs
> -----
> 
> src/backends/sage/sagebackend.cpp f5aed4c 
> src/backends/sage/sageextensions.h b1a24ef 
> src/backends/sage/sageextensions.cpp 9ced7ba 
> 
> Diff: https://git.reviewboard.kde.org/r/117636/diff/
> 
> 
> Testing
> -------
> 
> The diff compile without errors. You can test it importing any Python module using \
> the menu. 
> 
> Thanks,
> 
> Filipe Saraiva
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117636/">https://git.reviewboard.kde.org/r/117636/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good and works. \
Sorry for my late review. Please go ahead and commit!</pre>  <br />

<p>- Alexander Rieder</p>

<br />
<p>On April 18th, 2014, 8:55 p.m. UTC, Filipe Saraiva wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated April 18, 2014, 8:55 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This diff add SagePackagingExtension::importPackage to Sage backend, \
like in Python 2 backend. It enable a menu item in menu bar to import packages in \
Sage environment.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The diff compile without errors. You can test it importing any Python \
module using the menu.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/sage/sagebackend.cpp <span style="color: \
grey">(f5aed4c)</span></li>

 <li>src/backends/sage/sageextensions.h <span style="color: \
grey">(b1a24ef)</span></li>

 <li>src/backends/sage/sageextensions.cpp <span style="color: \
grey">(9ced7ba)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117636/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 