[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend
From: "Andrius da Costa Ribas" <andriusmao () gmail ! com>
Date: 2014-01-11 19:38:49
Message-ID: 20140111193849.5537.23001 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114964/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 7:38 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.
Repository: cantor
Description
-------
This typedef is in both kdewin's sys/types (msvc/include) and python config headers. \
By adding this definition the typedef present in kdewin is skipped.
Diffs
-----
src/backends/python2/CMakeLists.txt d27d88f
Diff: https://git.reviewboard.kde.org/r/114964/diff/
Testing
-------
Python backend builds and run fine from a clean MSVC build.
MinGW build was already okay, as per \
http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt
Thanks,
Andrius da Costa Ribas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114964/">https://git.reviewboard.kde.org/r/114964/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2014, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This typedef is in both kdewin's sys/types (msvc/include) and python \
config headers. By adding this definition the typedef present in kdewin is \
skipped.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Python backend builds and run fine from a clean MSVC build. MinGW build \
was already okay, as per \
http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/python2/CMakeLists.txt <span style="color: \
grey">(d27d88f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114964/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic