From kde-edu-devel Sat Jan 11 19:38:49 2014 From: "Andrius da Costa Ribas" Date: Sat, 11 Jan 2014 19:38:49 +0000 To: kde-edu-devel Subject: Re: Review Request 114964: Fix duplicated typedef for ssize_t on MSVC for python backend Message-Id: <20140111193849.5537.23001 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=138946917504826 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6364145148087114980==" --===============6364145148087114980== Content-Type: multipart/alternative; boundary="===============2463765413345976466==" --===============2463765413345976466== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/ ----------------------------------------------------------- (Updated Jan. 11, 2014, 7:38 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva. Repository: cantor Description ------- This typedef is in both kdewin's sys/types (msvc/include) and python config headers. By adding this definition the typedef present in kdewin is skipped. Diffs ----- src/backends/python2/CMakeLists.txt d27d88f Diff: https://git.reviewboard.kde.org/r/114964/diff/ Testing ------- Python backend builds and run fine from a clean MSVC build. MinGW build was already okay, as per http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt Thanks, Andrius da Costa Ribas --===============2463765413345976466== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114964/

This change has been marked as submitted.

Review request for KDE Edu, kdewin, Alexander Rieder, and Filipe Saraiva.

By Andrius da Costa Ribas.

Updated Jan. 11, 2014, 7:38 p.m.

Repository: cantor

Description

This typedef is in both kdewin's sys/types (msvc/include) and python config headers. By adding this definition the typedef present in kdewin is skipped.

Testing

Python backend builds and run fine from a clean MSVC build.
MinGW build was already okay, as per http://winkde.org/pub/kde/ports/win32/repository-4.12/logs/log-mingw-w32-kde_cantor.txt

Diffs

src/backends/python2/CMakeLists.txt (d27d88f)

View Diff

--===============2463765413345976466==-- --===============6364145148087114980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============6364145148087114980==--