'Re: Review Request 111032: Fix empty names in the find dialog.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 111032: Fix empty names in the find dialog.
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-01-11 16:48:41
Message-ID: 20140111164841.7621.78379 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111032/#review47212
-----------------------------------------------------------

This does not apply cleanly to master anymore, can you please rebase it?

- Albert Astals Cid

On Jan. 11, 2014, 4:48 p.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111032/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 4:48 p.m.)
> 
> 
> Review request for KDE Edu and KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Edit the setNames method of StarObject to expand greek characters in longname and \
> use the longname() method to get the name of the star in starcomponent.cpp. 
> This fixes the empty names in the find dialog, gives out better names for entries \
> and uses less code. 
> 
> Diffs
> -----
> 
> kstars/skycomponents/starcomponent.cpp a44e37a 
> kstars/skyobjects/starobject.cpp 8976341 
> 
> Diff: https://git.reviewboard.kde.org/r/111032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/111032/">https://git.reviewboard.kde.org/r/111032/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does not apply \
cleanly to master anymore, can you please rebase it?</pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On January 11th, 2014, 4:48 p.m. UTC, Aneesh Dogra wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and KStars.</div>
<div>By Aneesh Dogra.</div>

<p style="color: grey;"><i>Updated Jan. 11, 2014, 4:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Edit the setNames method of StarObject to expand greek characters in \
longname and use the longname() method to get the name of the star in \
starcomponent.cpp.

This fixes the empty names in the find dialog, gives out better names for entries and \
uses less code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skycomponents/starcomponent.cpp <span style="color: \
grey">(a44e37a)</span></li>

 <li>kstars/skyobjects/starobject.cpp <span style="color: grey">(8976341)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/111032/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 