From kde-edu-devel Sat Jan 11 16:48:41 2014 From: "Albert Astals Cid" Date: Sat, 11 Jan 2014 16:48:41 +0000 To: kde-edu-devel Subject: Re: Review Request 111032: Fix empty names in the find dialog. Message-Id: <20140111164841.7621.78379 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=138945894102626 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2738452033966296737==" --===============2738452033966296737== Content-Type: multipart/alternative; boundary="===============4362056828649062555==" --===============4362056828649062555== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111032/#review47212 ----------------------------------------------------------- This does not apply cleanly to master anymore, can you please rebase it? - Albert Astals Cid On Jan. 11, 2014, 4:48 p.m., Aneesh Dogra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/111032/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2014, 4:48 p.m.) > > > Review request for KDE Edu and KStars. > > > Repository: kstars > > > Description > ------- > > Edit the setNames method of StarObject to expand greek characters in longname and use the longname() method to get the name of the star in starcomponent.cpp. > > This fixes the empty names in the find dialog, gives out better names for entries and uses less code. > > > Diffs > ----- > > kstars/skycomponents/starcomponent.cpp a44e37a > kstars/skyobjects/starobject.cpp 8976341 > > Diff: https://git.reviewboard.kde.org/r/111032/diff/ > > > Testing > ------- > > > Thanks, > > Aneesh Dogra > > --===============4362056828649062555== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111032/

This does not apply cleanly to master anymore, can you please rebase it?

- Albert Astals Cid

On January 11th, 2014, 4:48 p.m. UTC, Aneesh Dogra wrote:

Review request for KDE Edu and KStars.

By Aneesh Dogra.

Updated Jan. 11, 2014, 4:48 p.m.

Repository: kstars

Description

Edit the setNames method of StarObject to expand greek characters in longname and use the longname() method to get the name of the star in starcomponent.cpp.

This fixes the empty names in the find dialog, gives out better names for entries and uses less code.

Diffs

kstars/skycomponents/starcomponent.cpp (a44e37a)
kstars/skyobjects/starobject.cpp (8976341)

View Diff

--===============4362056828649062555==-- --===============2738452033966296737== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============2738452033966296737==--