[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 112285: Adopt Google images to the new Google images search page
From: "Yuri Chornoivan" <yurchor () ukr ! net>
Date: 2013-09-26 5:59:21
Message-ID: 20130926055921.9902.92280 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 25, 2013, 8:46 p.m., Albert Astals Cid wrote:
> > The code looks reasonable, so for me, you can ship it.
> >
> > If you prefer someone else to try it to make sure it works on two people \
> > computers, you'll have to tell me what to do, since i'm not able to find how to \
> > invoke the script :D
Sure, the aim was to subject it to a wider testing.
The procedure to invoke the script is as follows:
1. Choose "Create a New Collection" on the starting page of Parley.
2. Choose the first language "English" and the second language "Catalan" (just in \
this example).
3. Push "OK" twice.
4. Enter "potato" in the first field on the lesson editor pane for English and \
"patata" for Catalan.
5. Use "File -> Save" to save the file somewhere.
6. Choose "Scripts -> Script Manager" from the menu.
7. Untick (or tick) the checkbox for "Example Parley Script", push "OK".
8. Select "potato" in the list.
9. Choose "Scripts -> Fetch Image".
Many thanks for testing the patch.
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112285/#review40817
-----------------------------------------------------------
On Aug. 26, 2013, 12:24 p.m., Yuri Chornoivan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112285/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 12:24 p.m.)
>
>
> Review request for KDE Edu and Frederik Gladhorn.
>
>
> Description
> -------
>
> Google has changed images search result page so now thumbnails are embedded into \
> the page code itself as binary data. This leads to Parley's Google image plugin \
> cannot file any images.
> The patch tries to change parsing strategy to obtain the address of the original \
> image and download this image instead of the thumbnail from the search page.
>
> Diffs
> -----
>
> plugins/google_images.py 5317ba6
>
> Diff: http://git.reviewboard.kde.org/r/112285/diff/
>
>
> Testing
> -------
>
> Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download \
> an average image from Wikipedia. All images are of good quality, everything seems \
> to work as expected.
>
> Thanks,
>
> Yuri Chornoivan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112285/">http://git.reviewboard.kde.org/r/112285/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 25th, 2013, 8:46 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code looks reasonable, so for me, you can ship it.
If you prefer someone else to try it to make sure it works on two people computers, \
you'll have to tell me what to do, since i'm not able to find how to invoke \
the script :D</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, the aim was to \
subject it to a wider testing.
The procedure to invoke the script is as follows:
1. Choose "Create a New Collection" on the starting page of Parley.
2. Choose the first language "English" and the second language \
"Catalan" (just in this example).
3. Push "OK" twice.
4. Enter "potato" in the first field on the lesson editor pane for English \
and "patata" for Catalan.
5. Use "File -> Save" to save the file somewhere.
6. Choose "Scripts -> Script Manager" from the menu.
7. Untick (or tick) the checkbox for "Example Parley Script", push \
"OK".
8. Select "potato" in the list.
9. Choose "Scripts -> Fetch Image".
Many thanks for testing the patch.</pre>
<br />
<p>- Yuri</p>
<br />
<p>On August 26th, 2013, 12:24 p.m. UTC, Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Frederik Gladhorn.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2013, 12:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Google has changed images search result page so now thumbnails are \
embedded into the page code itself as binary data. This leads to Parley's Google \
image plugin cannot file any images.
The patch tries to change parsing strategy to obtain the address of the original \
image and download this image instead of the thumbnail from the search page.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on several flashcard files. It takes ~2 seconds on 1MB channel to \
download an average image from Wikipedia. All images are of good quality, everything \
seems to work as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/google_images.py <span style="color: grey">(5317ba6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112285/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic