'Re: Review Request 108592: Added some more operations in analitza'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 108592: Added some more operations in analitza
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-09-25 23:48:53
Message-ID: 20130925234853.13914.2307 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108592/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 11:48 p.m.)

Status
------

This change has been discarded.

Review request for KDE Edu.

Description
-------

I added a few logic gates operations like xnor,nor ,log function lg(base 2),and \
complex functions -real,imaginary,conjugate,argument.

Diffs
-----

  analitza/operations.cpp 37b9820 
  analitza/operator.h dd7a93e 
  analitza/operator.cpp 4e5535b 
  analitza/tests/analitzatest.cpp f41aaf1 

Diff: http://git.reviewboard.kde.org/r/108592/diff/

Testing
-------

I am not sure about the complex functions rest seems fine I guess :p(Though compiled \
successfully)

File Attachments
----------------

removed complex functions 
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/analitza.patch

Thanks,

Heena Mahour

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108592/">http://git.reviewboard.kde.org/r/108592/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Heena Mahour.</div>

<p style="color: grey;"><i>Updated Sept. 25, 2013, 11:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I added a few logic gates operations like xnor,nor ,log function lg(base \
2),and complex functions -real,imaginary,conjugate,argument.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am not sure about the complex functions rest seems fine I guess \
:p(Though compiled successfully)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>analitza/operations.cpp <span style="color: grey">(37b9820)</span></li>

 <li>analitza/operator.h <span style="color: grey">(dd7a93e)</span></li>

 <li>analitza/operator.cpp <span style="color: grey">(4e5535b)</span></li>

 <li>analitza/tests/analitzatest.cpp <span style="color: grey">(f41aaf1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108592/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/analitza.patch">removed \
complex functions </a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 