'Review Request 112285: Adopt Google images to the new Google images search page'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 112285: Adopt Google images to the new Google images search page
From:       "Yuri Chornoivan" <yurchor () ukr ! net>
Date:       2013-08-26 12:24:33
Message-ID: 20130826122433.23850.80655 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112285/
-----------------------------------------------------------

Review request for KDE Edu and Frederik Gladhorn.

Description
-------

Google has changed images search result page so now thumbnails are embedded into the page code \
itself as binary data. This leads to Parley's Google image plugin cannot file any images.

The patch tries to change parsing strategy to obtain the address of the original image and \
download this image instead of the thumbnail from the search page.

Diffs
-----

  plugins/google_images.py 5317ba6 

Diff: http://git.reviewboard.kde.org/r/112285/diff/

Testing
-------

Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download an average \
image from Wikipedia. All images are of good quality, everything seems to work as expected.

Thanks,

Yuri Chornoivan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112285/">http://git.reviewboard.kde.org/r/112285/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Frederik Gladhorn.</div>
<div>By Yuri Chornoivan.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google has changed \
images search result page so now thumbnails are embedded into the page code itself as binary \
data. This leads to Parley&#39;s Google image plugin cannot file any images.

The patch tries to change parsing strategy to obtain the address of the original image and \
download this image instead of the thumbnail from the search page.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on several \
flashcard files. It takes ~2 seconds on 1MB channel to download an average image from \
Wikipedia. All images are of good quality, everything seems to work as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/google_images.py <span style="color: grey">(5317ba6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112285/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 