--===============5279501168651457934== Content-Type: multipart/alternative; boundary="===============5519398120880720574==" --===============5519398120880720574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112285/ ----------------------------------------------------------- Review request for KDE Edu and Frederik Gladhorn. Description ------- Google has changed images search result page so now thumbnails are embedded into the page code itself as binary data. This leads to Parley's Google image plugin cannot file any images. The patch tries to change parsing strategy to obtain the address of the original image and download this image instead of the thumbnail from the search page. Diffs ----- plugins/google_images.py 5317ba6 Diff: http://git.reviewboard.kde.org/r/112285/diff/ Testing ------- Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download an average image from Wikipedia. All images are of good quality, everything seems to work as expected. Thanks, Yuri Chornoivan --===============5519398120880720574== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112285/

Review request for KDE Edu and Frederik Gladhorn.

By Yuri Chornoivan.

Description

Google has changed images search result page so now thumbnails are embedded into the page code itself as binary data. This leads to Parley's Google image plugin cannot file any images.

The patch tries to change parsing strategy to obtain the address of the original image and download this image instead of the thumbnail from the search page.

Testing

Tested on several flashcard files. It takes ~2 seconds on 1MB channel to download an average image from Wikipedia. All images are of good quality, everything seems to work as expected.

Diffs

plugins/google_images.py (5317ba6)

View Diff

--===============5519398120880720574==-- --===============5279501168651457934== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============5279501168651457934==--